From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9618DA04C3 for ; Fri, 22 Nov 2019 15:42:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 880D1374; Fri, 22 Nov 2019 15:42:51 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id F261B1BE9A for ; Fri, 22 Nov 2019 15:42:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574433769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oMduAVF3JJmHLNJ2LL8EcGO33mYm6ZmZnfUHQRZmSXk=; b=TBhMrVQywzUTc+yciPc68BDQQUvGPe+dp4i0CihIuHLnLfNh/pzzoovwh07Xd0lJJkX2jw 6ECZXm1pQKJglSlH/OLEH8DGpVrfNJL/kRh8+mUFcgXiXvrhDp3g4rKrpny2Tk43U0mulE KCQ3AYhM51+o8BpBEuQbe0CRe+3TiqQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-pExdSrRaN_a_OFgxvkOBDg-1; Fri, 22 Nov 2019 09:42:48 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BD09184CAA1; Fri, 22 Nov 2019 14:42:47 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DC406E713; Fri, 22 Nov 2019 14:42:46 +0000 (UTC) From: Kevin Traynor To: Chaitanya Babu Talluri Cc: Akhil Goyal , dpdk stable Date: Fri, 22 Nov 2019 14:41:20 +0000 Message-Id: <20191122144131.21231-34-ktraynor@redhat.com> In-Reply-To: <20191122144131.21231-1-ktraynor@redhat.com> References: <20191122144131.21231-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: pExdSrRaN_a_OFgxvkOBDg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'examples/fips_validation: fix null dereferences' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/516d5762d5dc008885= d084d659c6b62d86f50cbe Thanks. Kevin. --- >From 516d5762d5dc008885d084d659c6b62d86f50cbe Mon Sep 17 00:00:00 2001 From: Chaitanya Babu Talluri Date: Wed, 25 Sep 2019 07:31:34 +0100 Subject: [PATCH] examples/fips_validation: fix null dereferences [ upstream commit 75b3dddf95ea0d5a1356115f748e1cc43de67886 ] One issue caught by Coverity 343408 *deref_parm: Directly dereferencing parameter val->val. In writeback_tdes_hex_str(), tmp_val is initialised to null. tmp_val.val is updated only if keys are found. If keys are not found,it doesn't fails but continues to invoke writeback_hex_str(),where val->val is accessed without null check. The fix is to return the error, if keys are not found in writeback_tdes_hex_str(). Coverity issue: 343408 Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing") Signed-off-by: Chaitanya Babu Talluri Acked-by: Akhil Goyal --- examples/fips_validation/fips_validation_tdes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fip= s_validation/fips_validation_tdes.c index 15ee434e1..2b262c9a0 100644 --- a/examples/fips_validation/fips_validation_tdes.c +++ b/examples/fips_validation/fips_validation_tdes.c @@ -213,4 +213,6 @@ writeback_tdes_hex_str(const char *key, char *dst, stru= ct fips_val *val) =09else if (strstr(key, KEY3_STR)) =09=09tmp_val.val =3D val->val + 16; +=09else +=09=09return -EINVAL; =20 =09return writeback_hex_str(key, dst, &tmp_val); --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-11-22 14:36:57.022847702 +0000 +++ 0034-examples-fips_validation-fix-null-dereferences.patch=092019-11-22 = 14:36:55.202149179 +0000 @@ -1 +1 @@ -From 75b3dddf95ea0d5a1356115f748e1cc43de67886 Mon Sep 17 00:00:00 2001 +From 516d5762d5dc008885d084d659c6b62d86f50cbe Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 75b3dddf95ea0d5a1356115f748e1cc43de67886 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org