From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
stable@dpdk.org, Dexuan Cui <decui@microsoft.com>
Subject: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
Date: Mon, 25 Nov 2019 09:13:00 -0800 [thread overview]
Message-ID: <20191125171300.3284-1-stephen@networkplumber.org> (raw)
In order to change RSS parameters, the host requires that RSS
is disable first.
Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
hv->rss_ind[i] = reta_conf[idx].reta[shift];
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
return err;
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
--
2.20.1
next reply other threads:[~2019-11-25 17:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 17:13 Stephen Hemminger [this message]
2019-11-26 13:52 ` Ferruh Yigit
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
2019-11-26 3:28 [dpdk-stable] [PATCH] " Dexuan Cui
2019-11-26 3:32 ` Dexuan Cui
2019-12-09 21:29 ` Dexuan Cui
2019-12-10 2:31 ` Donald_Lee
2019-12-10 6:59 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125171300.3284-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=decui@microsoft.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).