From: Bruce Richardson <bruce.richardson@intel.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com
Subject: Re: [dpdk-stable] [PATCH v2] kernel/linux: fix kernel dir for meson
Date: Tue, 3 Dec 2019 13:58:35 +0000 [thread overview]
Message-ID: <20191203135835.GA45@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191203123322.GA22356@intel.com>
On Tue, Dec 03, 2019 at 08:33:22PM +0800, Ye Xiaolong wrote:
> On 12/03, Bruce Richardson wrote:
> >On Tue, Dec 03, 2019 at 01:29:17PM +0800, Xiaolong Ye wrote:
> >> kernel_dir option in meson build is equivalent to RTE_KERNELDIR in make
> >> system, for cross-compilation case, users would specify it as local
> >> kernel src dir like
> >>
> >> /<user local dir>/target-arm_glibc/linux-arm/linux-4.19.81/
> >>
> >> Current meson build would fail to compile kernel module if user specify
> >> kernel_dir as above, this patch fixes this issue.
> >>
> >> Fixes: 317832f97c16 ("kernel/linux: fix modules install path")
> >> Cc: stable@dpdk.org
> >> Cc: iryzhov@nfware.com
> >>
> >> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >> ---
> >>
> >> V2 changes:
> >>
> >> 1. handle both normal and cross-compilation cases
> >>
> >We need to handle both, but they need to be handled without breaking the
> >currently working case where we pass in /lib/modules/$(uname -r)/ as the
> >kerneldir path.
>
> So you mean we should allow user to specify both /lib/modules/$(uname -r) and
> /lib/modules/$(uname -r)/build as kernel_dir for normal case?
>
That is up to you, but we need to still allow the former case so as to
avoid breaking backward compatibility for existing build setups. Therefore
I suggest supporting both is recommended.
/Bruce
next prev parent reply other threads:[~2019-12-03 13:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 6:14 [dpdk-stable] [PATCH] " Xiaolong Ye
2019-12-02 8:10 ` Igor Ryzhov
2019-12-02 8:39 ` Ye Xiaolong
2019-12-02 9:16 ` Igor Ryzhov
2019-12-02 11:34 ` Ye Xiaolong
2019-12-02 12:08 ` Bruce Richardson
2019-12-02 15:44 ` Ye Xiaolong
2019-12-03 5:33 ` Ye Xiaolong
2019-12-03 10:10 ` Bruce Richardson
2019-12-03 5:29 ` [dpdk-stable] [PATCH v2] " Xiaolong Ye
2019-12-03 10:11 ` Bruce Richardson
2019-12-03 12:33 ` Ye Xiaolong
2019-12-03 13:58 ` Bruce Richardson [this message]
2019-12-03 15:01 ` Ye Xiaolong
2019-12-03 15:59 ` [dpdk-stable] [PATCH v3] " Xiaolong Ye
2019-12-04 13:51 ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2019-12-04 14:18 ` Ye Xiaolong
2019-12-04 15:12 ` Bruce Richardson
2019-12-08 1:26 ` Ye Xiaolong
2019-12-09 12:12 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203135835.GA45@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=iryzhov@nfware.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).