From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FAA0A04B5 for ; Tue, 3 Dec 2019 19:28:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25FBB235; Tue, 3 Dec 2019 19:28:23 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id F39C3235 for ; Tue, 3 Dec 2019 19:28:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=571gHkhdTixJjMPBYxZQiaBi/Lk1tya0apIJpg/bOtw=; b=VTVHGmq97uAW516MlDugcps5XU3yABPncz+sxCK5LNZLJqH/HAe/Zh5RNONcIBSGlLE8er 3ENFhIeAFoflJtSEuUPes/PMHQXyIWEe2azsM3IEnhpGBa1Odd4wvmo3mbRDQa9eAF6kl3 wUl0F9DpSyemsVCxFfOUY5geXYtNNB8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-sdnlZBP2MWWt4V8oA4mysg-1; Tue, 03 Dec 2019 13:28:17 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBA1B10054E3; Tue, 3 Dec 2019 18:28:15 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF5645C554; Tue, 3 Dec 2019 18:28:14 +0000 (UTC) From: Kevin Traynor To: Yasufumi Ogawa Cc: Ferruh Yigit , dpdk stable Date: Tue, 3 Dec 2019 18:26:33 +0000 Message-Id: <20191203182714.17297-24-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: sdnlZBP2MWWt4V8oA4mysg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/null: fix multi-process Rx and Tx' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/74677ac9c49816a7fb= d81f8f0aad753dee504216 Thanks. Kevin. --- >From 74677ac9c49816a7fbd81f8f0aad753dee504216 Mon Sep 17 00:00:00 2001 From: Yasufumi Ogawa Date: Sun, 29 Sep 2019 11:41:41 +0900 Subject: [PATCH] net/null: fix multi-process Rx and Tx [ upstream commit bccc77a6a74a6c30e68f88b2ef0d0099c45898c8 ] Packet processing in secondary process cannot work because rx_pkt_burst and tx_pkt_burst in eth_dev are not initialized while probing device. This patch is to the initialization. Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") Signed-off-by: Yasufumi Ogawa Reviewed-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_nul= l.c index da081362c..1067e6e4e 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -622,4 +622,11 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) =09=09eth_dev->dev_ops =3D &ops; =09=09eth_dev->device =3D &dev->device; +=09=09if (packet_copy) { +=09=09=09eth_dev->rx_pkt_burst =3D eth_null_copy_rx; +=09=09=09eth_dev->tx_pkt_burst =3D eth_null_copy_tx; +=09=09} else { +=09=09=09eth_dev->rx_pkt_burst =3D eth_null_rx; +=09=09=09eth_dev->tx_pkt_burst =3D eth_null_tx; +=09=09} =09=09rte_eth_dev_probing_finish(eth_dev); =09=09return 0; --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:53.235848274 +0000 +++ 0024-net-null-fix-multi-process-Rx-and-Tx.patch=092019-12-03 17:29:51.7= 41750141 +0000 @@ -1 +1 @@ -From bccc77a6a74a6c30e68f88b2ef0d0099c45898c8 Mon Sep 17 00:00:00 2001 +From 74677ac9c49816a7fbd81f8f0aad753dee504216 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bccc77a6a74a6c30e68f88b2ef0d0099c45898c8 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index e2ff41a22..3a8904729 100644 +index da081362c..1067e6e4e 100644 @@ -23 +24 @@ -@@ -591,4 +591,11 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) +@@ -622,4 +622,11 @@ rte_pmd_null_probe(struct rte_vdev_device *dev)