From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78BB5A04B5 for ; Tue, 3 Dec 2019 19:28:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 572C51BF7C; Tue, 3 Dec 2019 19:28:24 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id A75BA235 for ; Tue, 3 Dec 2019 19:28:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VCR0sb/Yx8tk/FpQHLce+aYuQif8LEmGp1+Ou0dbRLU=; b=huv48w10jm9hw/MVgiwj5uEZYogQf+YZ+DLqDmgbEtr58Joh1rJ9+cbEv9kq3KCvMVnwpA wd6qAlVKXgiI6nXoKw2c2OFNAWDRr7e4gHj0kCs8Wew333A3bq1EIm8Uv3Ze/+rTLnhhcL /KOa1Ume09DEHWIv6+1Dag6cGlIH484= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-vgTjROVVNOi-LLb5OMuXqQ-1; Tue, 03 Dec 2019 13:28:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 334731883522; Tue, 3 Dec 2019 18:28:18 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5ABB05C240; Tue, 3 Dec 2019 18:28:15 +0000 (UTC) From: Kevin Traynor To: Gavin Hu Cc: Steve Capper , Ruifeng Wang , Phil Yang , Ajit Khaparde , dpdk stable Date: Tue, 3 Dec 2019 18:26:34 +0000 Message-Id: <20191203182714.17297-25-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: vgTjROVVNOi-LLb5OMuXqQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnxt: remove duplicate barrier' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/5855cfa39e5d58e880= 790dbd07e651882dc2458a Thanks. Kevin. --- >From 5855cfa39e5d58e880790dbd07e651882dc2458a Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Mon, 16 Sep 2019 19:27:16 +0800 Subject: [PATCH] net/bnxt: remove duplicate barrier [ upstream commit 4a1721107c30603e078a611e99a4183de178fd7d ] As there is an inclusive rte_io_wmb within the following rte_write32() API who rings the doorbell, this makes the above rte_wmb unnecessary and remove it. Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") Signed-off-by: Gavin Hu Reviewed-by: Steve Capper Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 69b45283d..cecf8abdc 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -102,7 +102,4 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void= *msg, =09=09msg_len =3D sizeof(short_input); =20 -=09=09/* Sync memory write before updating doorbell */ -=09=09rte_wmb(); - =09=09max_req_len =3D BNXT_HWRM_SHORT_REQ_LEN; =09} --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:53.285979484 +0000 +++ 0025-net-bnxt-remove-duplicate-barrier.patch=092019-12-03 17:29:51.7437= 50099 +0000 @@ -1 +1 @@ -From 4a1721107c30603e078a611e99a4183de178fd7d Mon Sep 17 00:00:00 2001 +From 5855cfa39e5d58e880790dbd07e651882dc2458a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4a1721107c30603e078a611e99a4183de178fd7d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 174dc75d5..e73d8ed76 100644 +index 69b45283d..cecf8abdc 100644 @@ -26 +27 @@ -@@ -128,7 +128,4 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, voi= d *msg, +@@ -102,7 +102,4 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, voi= d *msg,