From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB51DA04B5 for ; Tue, 3 Dec 2019 19:28:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E5A11BF76; Tue, 3 Dec 2019 19:28:26 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id EFFF21BF82 for ; Tue, 3 Dec 2019 19:28:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d8GT3gaf3ziorp6sj1UOaaY++iAQ/u6BmDSp3EaTfu8=; b=StV74lkisDT0QyVwLPpZZ5o3/rygQ3JOLdz88Wyb2G/sBap80Qy5R4Nk3i+EW+cIuSejQY eyMepnVEfxsRt7jC6mAp7C0lbhJNw2QTIgHD1mMwdfXJY/wTUDbLOT+c5u7NOVAOXEqyoQ 9wTwbDB/Ds39eCRQmb+RLOIVMv9Dm2o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-yTrxGf4TPgyNcAPruYLWHg-1; Tue, 03 Dec 2019 13:28:22 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 167EE8017CC; Tue, 3 Dec 2019 18:28:21 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A18A5C240; Tue, 3 Dec 2019 18:28:19 +0000 (UTC) From: Kevin Traynor To: Gavin Hu Cc: Ajit Khaparde , dpdk stable Date: Tue, 3 Dec 2019 18:26:36 +0000 Message-Id: <20191203182714.17297-27-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: yTrxGf4TPgyNcAPruYLWHg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnxt: enforce IO barrier for doorbell command' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/a60ed73cd01caeaec5= 80bedf3197e7a7b27f3bb2 Thanks. Kevin. --- >From a60ed73cd01caeaec580bedf3197e7a7b27f3bb2 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Mon, 16 Sep 2019 19:27:18 +0800 Subject: [PATCH] net/bnxt: enforce IO barrier for doorbell command [ upstream commit dda8e0e48723fc90e6222fcc1b04b94f240ae9b2 ] The doorbell ringing operation requires a rte_io_mb immediately to make the command complete and visible to the device before reading the response, otherwise it may read stale or invalid responses. Fixes: ca241d9a0952 ("net/bnxt: use I/O device memory read/write API") Signed-off-by: Gavin Hu Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7e6209a55..a57e5cf36 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -121,4 +121,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, voi= d *msg, =09bar =3D (uint8_t *)bp->bar0 + mb_trigger_offset; =09rte_write32(1, bar); +=09/* +=09 * Make sure the channel doorbell ring command complete before +=09 * reading the response to avoid getting stale or invalid +=09 * responses. +=09 */ +=09rte_io_mb(); =20 =09/* Poll for the valid bit */ --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:53.405272464 +0000 +++ 0027-net-bnxt-enforce-IO-barrier-for-doorbell-command.patch=092019-12-0= 3 17:29:51.747750016 +0000 @@ -1 +1 @@ -From dda8e0e48723fc90e6222fcc1b04b94f240ae9b2 Mon Sep 17 00:00:00 2001 +From a60ed73cd01caeaec580bedf3197e7a7b27f3bb2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dda8e0e48723fc90e6222fcc1b04b94f240ae9b2 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index d7c33d21e..cdb6fa4f7 100644 +index 7e6209a55..a57e5cf36 100644 @@ -23 +24 @@ -@@ -147,4 +147,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, vo= id *msg, +@@ -121,4 +121,10 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, vo= id *msg,