From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C25FFA04B5 for ; Tue, 3 Dec 2019 19:28:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6B4C1BF76; Tue, 3 Dec 2019 19:28:29 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 0827B235 for ; Tue, 3 Dec 2019 19:28:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WfTayiz8wqfLRYGDrCWri+wLu7fs3rsTSsXSvdLbtxQ=; b=IgNDx5NlxGs/0vb6NkuOQeOPVJX7unirAQSNCvghOd4N9jEp/QvNIYV1S9z8TfEo1rSUCH V7f7mdLXdadkx6xOa2tENifxX2tmVtWm0+MnrNdqSsdLtyzB+HPIUvWQm5/T0OW3X1LVwV XoEkf+untw3dG2wg31Cj+aBTpjXqpRM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-piyl1vkcPqivVqaEeZLTFg-1; Tue, 03 Dec 2019 13:28:24 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B64B8017CC; Tue, 3 Dec 2019 18:28:23 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CF875C240; Tue, 3 Dec 2019 18:28:21 +0000 (UTC) From: Kevin Traynor To: Santoshkumar Karanappa Rastapur Cc: Lance Richardson , Somnath Kotur , Ajit Khaparde , dpdk stable Date: Tue, 3 Dec 2019 18:26:37 +0000 Message-Id: <20191203182714.17297-28-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: piyl1vkcPqivVqaEeZLTFg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bnxt: fix flow steering' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/c8b5fcd7003f099398= 0937700193b22e727e0b0f Thanks. Kevin. --- >From c8b5fcd7003f0993980937700193b22e727e0b0f Mon Sep 17 00:00:00 2001 From: Santoshkumar Karanappa Rastapur Date: Wed, 2 Oct 2019 10:17:30 -0700 Subject: [PATCH] net/bnxt: fix flow steering [ upstream commit d43fe8ea0c40c5534d83950bff08aa89457a3fd7 ] When user creates a flow similar to an existing flow with just the destination queue change, we delete the old filter and allocate a new one with this destination queue change. We were also allocating a new L2 filter matching the same destination mac resulting in 2 L2 filters for the same destination mac. This was causing any flow matching the destination mac to be steered to this queue instead of the default queue. Fixed it by deleting this stale L2 filter. Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") Signed-off-by: Santoshkumar Karanappa Rastapur Reviewed-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 6a5995389..e4fd0d935 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -969,4 +969,8 @@ bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_i= nfo *nf) =09=09=09=09if (mf->dst_id =3D=3D nf->dst_id) =09=09=09=09=09return -EEXIST; +=09=09=09=09/* Clear the new L2 filter that was created +=09=09=09=09 * earlier in bnxt_validate_and_parse_flow. +=09=09=09=09 */ +=09=09=09=09bnxt_hwrm_clear_l2_filter(bp, nf); =09=09=09=09/* =09=09=09=09 * Same Flow, Different queue --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:53.461902215 +0000 +++ 0028-net-bnxt-fix-flow-steering.patch=092019-12-03 17:29:51.748749995 += 0000 @@ -1 +1 @@ -From d43fe8ea0c40c5534d83950bff08aa89457a3fd7 Mon Sep 17 00:00:00 2001 +From c8b5fcd7003f0993980937700193b22e727e0b0f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d43fe8ea0c40c5534d83950bff08aa89457a3fd7 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index deb9733e9..be9b6fad3 100644 +index 6a5995389..e4fd0d935 100644 @@ -31 +32 @@ -@@ -1029,4 +1029,8 @@ bnxt_match_filter(struct bnxt *bp, struct bnxt_filte= r_info *nf) +@@ -969,4 +969,8 @@ bnxt_match_filter(struct bnxt *bp, struct bnxt_filter_= info *nf)