From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4B31A04B5 for ; Tue, 3 Dec 2019 19:29:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C92241BF97; Tue, 3 Dec 2019 19:29:06 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id DC85B1BFA9 for ; Tue, 3 Dec 2019 19:29:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jhxq+FT8DKQdT30NMS8DR/ozBQKta2XNvsA6LMItXds=; b=FjM2I2uxpKW4Mkp33/KGj8HS+0+JJEBHyeiU2HWmX5G0MltOuhtzIYVsvSFC0knKcDa7Xr DELs807hHBRNBHWCdDvI6PAo/YCKUd+JGlLXFBq7sySg1Te8eabPJFr+6IXyizV3tuh/a8 9pveTanCHc6gMIwe+Gi9e4v846G9CG8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-Rl2rQ5ltNz-bBXz96EwVnw-1; Tue, 03 Dec 2019 13:29:01 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 141BF10054E3; Tue, 3 Dec 2019 18:29:00 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27FFB5C240; Tue, 3 Dec 2019 18:28:58 +0000 (UTC) From: Kevin Traynor To: Damian Nowak Cc: Fiona Trahe , dpdk stable Date: Tue, 3 Dec 2019 18:26:59 +0000 Message-Id: <20191203182714.17297-50-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: Rl2rQ5ltNz-bBXz96EwVnw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'crypto/qat: fix null auth when using VFIO' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/ac0a49ed92588f961b= 1f5e659d27c70f078eea13 Thanks. Kevin. --- >From ac0a49ed92588f961b1f5e659d27c70f078eea13 Mon Sep 17 00:00:00 2001 From: Damian Nowak Date: Fri, 9 Aug 2019 11:29:01 +0200 Subject: [PATCH] crypto/qat: fix null auth when using VFIO [ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ] When running auth NULL cases while using vfio_pci, DMAR read/write faults appear. It happens even if digest_length is set to 0. This is caused by auth_res_addr initialized as 0x0. Fixes: 4e0955bddb08 ("crypto/qat: fix null auth algo overwrite") Signed-off-by: Damian Nowak Acked-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c index 7515a55d0..f7ea1a5dd 100644 --- a/drivers/crypto/qat/qat_sym.c +++ b/drivers/crypto/qat/qat_sym.c @@ -307,7 +307,6 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg, =09=09min_ofs =3D auth_ofs; =20 -=09=09if (likely(ctx->qat_hash_alg !=3D ICP_QAT_HW_AUTH_ALGO_NULL)) -=09=09=09auth_param->auth_res_addr =3D -=09=09=09=09=09op->sym->auth.digest.phys_addr; +=09=09auth_param->auth_res_addr =3D +=09=09=09op->sym->auth.digest.phys_addr; =20 =09} --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:54.654819123 +0000 +++ 0050-crypto-qat-fix-null-auth-when-using-VFIO.patch=092019-12-03 17:29:= 51.774749453 +0000 @@ -1 +1 @@ -From 65beb9abca6dbb2167a53ab31d79e03f0857357b Mon Sep 17 00:00:00 2001 +From ac0a49ed92588f961b1f5e659d27c70f078eea13 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 65beb9abca6dbb2167a53ab31d79e03f0857357b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 5ff4aa1e5..5c9904cbf 100644 +index 7515a55d0..f7ea1a5dd 100644 @@ -25 +26 @@ -@@ -310,7 +310,6 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg, +@@ -307,7 +307,6 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg,