From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A58EA04B5 for ; Tue, 3 Dec 2019 19:29:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F73F1BFBC; Tue, 3 Dec 2019 19:29:10 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 0A87A1BF97 for ; Tue, 3 Dec 2019 19:29:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575397748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZOhxYs+FX+6A1Jhs2urDnQ70VDnmI+bopddOJWrwCN8=; b=i1pWQ5u5WXiZBdDwaXM9wk1YfC6YoJ9EuwkLF2pNz/vZwzVUfdCDlnpNcthfrWmN1vtc8F lQV2C8cDTYE0zeCE5YMn4+v3UERsRbtAAwCWyE36Te/Bf18YsliFm+KrbzxXhpIMSrXoe/ 6y5xT+uDJDCEhNmVD0z7iQVXhRfftT4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-uVQJklvmM-GdCzHNCShVdQ-1; Tue, 03 Dec 2019 13:29:07 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D17C1883521; Tue, 3 Dec 2019 18:29:06 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-10.ams2.redhat.com [10.36.117.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D70B5C240; Tue, 3 Dec 2019 18:29:05 +0000 (UTC) From: Kevin Traynor To: Seth Howell Cc: Gaetan Rivet , dpdk stable Date: Tue, 3 Dec 2019 18:27:03 +0000 Message-Id: <20191203182714.17297-54-ktraynor@redhat.com> In-Reply-To: <20191203182714.17297-1-ktraynor@redhat.com> References: <20191203182714.17297-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: uVQJklvmM-GdCzHNCShVdQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'bus/pci: remove useless link dependency on ethdev' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/10/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/65d6da1c84cdd75c5d= 0a2c94d40606d0e7459e96 Thanks. Kevin. --- >From 65d6da1c84cdd75c5d0a2c94d40606d0e7459e96 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Fri, 11 Oct 2019 13:56:07 -0700 Subject: [PATCH] bus/pci: remove useless link dependency on ethdev [ upstream commit c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa ] The makefile in drivers/bus/pci specified rte_ethdev as a dependency for the library. However there are no actual symbols from librte_ethdev used in librte_bus_pci. Including librte_ethdev as a dependency only becomes a problem in some niche cases like when attempting to build the rte_bus_pci library as a shared object without building the rte_ethdev library. I specifically ran into this when trying to build the DPDK included as an SPDK submodule on a FreeBSD machine. I figure that since there are no real dependencies between the two, we should enable building librte_bus_pci without librte_ethdev. Fixes: c752998b5e2e ("pci: introduce library and driver") Signed-off-by: Seth Howell Acked-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile index f33e0120f..b69609156 100644 --- a/drivers/bus/pci/Makefile +++ b/drivers/bus/pci/Makefile @@ -27,5 +27,5 @@ CFLAGS +=3D -DALLOW_EXPERIMENTAL_API =20 LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS +=3D -lrte_ethdev -lrte_pci -lrte_kvargs +LDLIBS +=3D -lrte_pci -lrte_kvargs =20 include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-03 17:29:54.862992262 +0000 +++ 0054-bus-pci-remove-useless-link-dependency-on-ethdev.patch=092019-12-0= 3 17:29:51.776749412 +0000 @@ -1 +1 @@ -From c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa Mon Sep 17 00:00:00 2001 +From 65d6da1c84cdd75c5d0a2c94d40606d0e7459e96 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 68c1f3fde..45d12427a 100644 +index f33e0120f..b69609156 100644 @@ -32 +33 @@ -@@ -26,5 +26,5 @@ CFLAGS +=3D -DALLOW_EXPERIMENTAL_API +@@ -27,5 +27,5 @@ CFLAGS +=3D -DALLOW_EXPERIMENTAL_API