[dpdk-stable] [PATCH 18.11] net/bnxt: advertise scatter Rx offload capability

[dpdk-stable] [PATCH 18.11] net/bnxt: advertise scatter Rx offload capability

[Lance Richardson]

[ upstream commit 94d4afd2d167886f9eb4833443478e048cd60588 ]

Scattered receive is supported but not included in receive offload
capabilities. Fix by adding it to the receive offload capabilities..

Fixes: 9c1507d96ab8 ("net/bnxt: switch to the new offload API")

Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
Note: this patch drops the upstream hunk related to vector
mode support, which is not present in 18.11.

 drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 2f3e067ed..47dde067a 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -150,7 +150,8 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
 				     DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
 				     DEV_RX_OFFLOAD_JUMBO_FRAME | \
 				     DEV_RX_OFFLOAD_KEEP_CRC | \
-				     DEV_RX_OFFLOAD_TCP_LRO)
+				     DEV_RX_OFFLOAD_TCP_LRO | \
+				     DEV_RX_OFFLOAD_SCATTER)
 
 static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
 static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
-- 
2.17.1

Re: [dpdk-stable] [PATCH 18.11] net/bnxt: advertise scatter Rx offload capability

[Kevin Traynor]

Hi Lance,

On 04/12/2019 21:05, Lance Richardson wrote:
> [ upstream commit 94d4afd2d167886f9eb4833443478e048cd60588 ]
> 
> Scattered receive is supported but not included in receive offload
> capabilities. Fix by adding it to the receive offload capabilities..
> 
> Fixes: 9c1507d96ab8 ("net/bnxt: switch to the new offload API")
> 
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> Note: this patch drops the upstream hunk related to vector
> mode support, which is not present in 18.11.
> 

The hunk below would have applied, but I was not confident to do it
because there bnxt_scattered_rx() was missing. Thanks for the backport,
I've added to the queue [1] and will be pushed next week.

Kevin.

[1]
https://github.com/kevintraynor/dpdk-stable-queue/commit/2d4e5e8980657fa2194203b9cd01d56446d00991

>  drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 2f3e067ed..47dde067a 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -150,7 +150,8 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
>  				     DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
>  				     DEV_RX_OFFLOAD_JUMBO_FRAME | \
>  				     DEV_RX_OFFLOAD_KEEP_CRC | \
> -				     DEV_RX_OFFLOAD_TCP_LRO)
> +				     DEV_RX_OFFLOAD_TCP_LRO | \
> +				     DEV_RX_OFFLOAD_SCATTER)
>  
>  static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
>  static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
>