* [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
@ 2019-11-25 17:13 Stephen Hemminger
2019-11-26 13:52 ` Ferruh Yigit
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-11-25 17:13 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, stable, Dexuan Cui
In order to change RSS parameters, the host requires that RSS
is disable first.
Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
hv->rss_ind[i] = reta_conf[idx].reta[shift];
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
return err;
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters
2019-11-25 17:13 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Stephen Hemminger
@ 2019-11-26 13:52 ` Ferruh Yigit
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-11-26 13:52 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: stable, Dexuan Cui
On 11/25/2019 5:13 PM, Stephen Hemminger wrote:
> In order to change RSS parameters, the host requires that RSS
> is disable first.
>
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <20191206235248.24970-1-stephen@networkplumber.org>]
* [dpdk-stable] [PATCH v2 1/2] net/netvsc: fix RSS offload flag
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
@ 2019-12-06 23:52 ` Stephen Hemminger
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-12-06 23:52 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, pbhagavatula, stable
The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD
with testpmd. The netvsc driver fails during configure step:
Configuring Port 1 (socket 0)
hn_dev_configure(): unsupported RX offload: 0x80000
Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: pbhagavatula@marvell.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/netvsc/hn_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..5ef7a452cc69 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -42,7 +42,8 @@
DEV_TX_OFFLOAD_VLAN_INSERT)
#define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \
- DEV_RX_OFFLOAD_VLAN_STRIP)
+ DEV_RX_OFFLOAD_VLAN_STRIP | \
+ DEV_RX_OFFLOAD_RSS_HASH)
int hn_logtype_init;
int hn_logtype_driver;
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-stable] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
@ 2019-12-06 23:52 ` Stephen Hemminger
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2019-12-06 23:52 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, stable, Abhishek Marathe, Dexuan Cui
In order to change RSS parameters, the host requires that RSS
is disable first.
Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Tested-by: Abhishek Marathe <abmarath@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 5ef7a452cc69..159116f7f691 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
hv->rss_ind[i] = reta_conf[idx].reta[shift];
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
return err;
}
+ err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+ if (err) {
+ PMD_DRV_LOG(NOTICE,
+ "rss disable failed");
+ return err;
+ }
+
err = hn_rndis_conf_rss(hv, 0);
if (err) {
PMD_DRV_LOG(NOTICE,
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-06 23:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 17:13 [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters Stephen Hemminger
2019-11-26 13:52 ` Ferruh Yigit
[not found] ` <20191206235248.24970-1-stephen@networkplumber.org>
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 1/2] net/netvsc: fix RSS offload flag Stephen Hemminger
2019-12-06 23:52 ` [dpdk-stable] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).