From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11558A04F0 for ; Tue, 10 Dec 2019 16:00:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 088A91B13C; Tue, 10 Dec 2019 16:00:51 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id E7A061B13C for ; Tue, 10 Dec 2019 16:00:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pBmF7/FnVXurnbM2Y3SZBhdA/M24zsCwlCBxxE6SkcM=; b=AW2B5G5N3FfecVWk+LJ01Xnw5YahozYN3ZDgeHlN2MPDW509MwjZEMLUXgjqFpHWzSaU3G 4MeOkro6dwhvkU9D0SqPZM3qKJ9o6xCx4DKJwLp+xyiU0V6Rmb6nMEuALCMrZk3ZepFq5Q d2nKA8XqmVvRjydwQNILpiU25Fztl5M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-75-nBy-K9MCPUKMptCPK4PJiQ-1; Tue, 10 Dec 2019 10:00:45 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E68C01883524; Tue, 10 Dec 2019 15:00:43 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5155A5D9C5; Tue, 10 Dec 2019 15:00:39 +0000 (UTC) From: Kevin Traynor To: Dilshod Urazov Cc: Andrew Rybchenko , Maxime Coquelin , dpdk stable Date: Tue, 10 Dec 2019 14:59:01 +0000 Message-Id: <20191210145937.32755-27-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: nBy-K9MCPUKMptCPK4PJiQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/virtio: reject deferred Rx start' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/3a1d14413a19c65e8a= 5b42ec131de319f8e08c03 Thanks. Kevin. --- >From 3a1d14413a19c65e8a5b42ec131de319f8e08c03 Mon Sep 17 00:00:00 2001 From: Dilshod Urazov Date: Wed, 9 Oct 2019 13:32:05 +0100 Subject: [PATCH] net/virtio: reject deferred Rx start [ upstream commit 955d7c1f03d049b2018db3d2c4a78920368d7aa3 ] Deferred start Rx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_r= xtx.c index 0fface207..c7df33829 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -556,5 +556,5 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, =09=09=09uint16_t nb_desc, =09=09=09unsigned int socket_id __rte_unused, -=09=09=09const struct rte_eth_rxconf *rx_conf __rte_unused, +=09=09=09const struct rte_eth_rxconf *rx_conf, =09=09=09struct rte_mempool *mp) { @@ -566,4 +566,9 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, =09PMD_INIT_FUNC_TRACE(); =20 +=09if (rx_conf->rx_deferred_start) { +=09=09PMD_INIT_LOG(ERR, "Rx deferred start is not supported"); +=09=09return -EINVAL; +=09} + =09if (nb_desc =3D=3D 0 || nb_desc > vq->vq_nentries) =09=09nb_desc =3D vq->vq_nentries; --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:40.950105941 +0000 +++ 0027-net-virtio-reject-deferred-Rx-start.patch=092019-12-10 14:49:39.03= 6458066 +0000 @@ -1 +1 @@ -From 955d7c1f03d049b2018db3d2c4a78920368d7aa3 Mon Sep 17 00:00:00 2001 +From 3a1d14413a19c65e8a5b42ec131de319f8e08c03 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 955d7c1f03d049b2018db3d2c4a78920368d7aa3 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index b5fc4ecbe..405c313f2 100644 +index 0fface207..c7df33829 100644 @@ -22 +23 @@ -@@ -930,5 +930,5 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, +@@ -556,5 +556,5 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, @@ -29 +30 @@ -@@ -940,4 +940,9 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, +@@ -566,4 +566,9 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,