From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E22FA04F0 for ; Tue, 10 Dec 2019 16:00:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DF2D1B9B7; Tue, 10 Dec 2019 16:00:53 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 720451B9B7 for ; Tue, 10 Dec 2019 16:00:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aJ4Z1zeTElK0bHZUsI7HLW7vMDdNm+x74RvYGM+/WSs=; b=hcHK1LT7+eQrYHcvX9nCCpIBU/ginYFkfYnA5RlbZgukLsVZUADGTxragefdz1f59dmoEI NiUas6FzVVDloBCRAgUPUJfh9GHXRo0/6FQN3v6EVDO7l7+YNiYkpJ12+uVTRml41Bl2qH a0rVReEA734bQhgmP3Va9Yku5W7pjW4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-_RghOpR4P2yn1GuF5sPTOw-1; Tue, 10 Dec 2019 10:00:46 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF375107ACE5; Tue, 10 Dec 2019 15:00:45 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4FE625D9C5; Tue, 10 Dec 2019 15:00:44 +0000 (UTC) From: Kevin Traynor To: Dilshod Urazov Cc: Andrew Rybchenko , Tiwei Bie , Maxime Coquelin , dpdk stable Date: Tue, 10 Dec 2019 14:59:02 +0000 Message-Id: <20191210145937.32755-28-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: _RghOpR4P2yn1GuF5sPTOw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/virtio: reject deferred Tx start' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/4ce6b6a7fe4498c12c= 95460619aa1112bb820475 Thanks. Kevin. --- >From 4ce6b6a7fe4498c12c95460619aa1112bb820475 Mon Sep 17 00:00:00 2001 From: Dilshod Urazov Date: Wed, 9 Oct 2019 13:32:06 +0100 Subject: [PATCH] net/virtio: reject deferred Tx start [ upstream commit c0e03310ee90c5d7aff9fffb243f3374f0b0cd61 ] Deferred start Tx queue is not supported by the driver. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Reviewed-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_rxtx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_r= xtx.c index c7df33829..306009d96 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -688,4 +688,9 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, =09PMD_INIT_FUNC_TRACE(); =20 +=09if (tx_conf->tx_deferred_start) { +=09=09PMD_INIT_LOG(ERR, "Tx deferred start is not supported"); +=09=09return -EINVAL; +=09} + =09if (nb_desc =3D=3D 0 || nb_desc > vq->vq_nentries) =09=09nb_desc =3D vq->vq_nentries; --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:41.013963172 +0000 +++ 0028-net-virtio-reject-deferred-Tx-start.patch=092019-12-10 14:49:39.03= 8458028 +0000 @@ -1 +1 @@ -From c0e03310ee90c5d7aff9fffb243f3374f0b0cd61 Mon Sep 17 00:00:00 2001 +From 4ce6b6a7fe4498c12c95460619aa1112bb820475 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c0e03310ee90c5d7aff9fffb243f3374f0b0cd61 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 405c313f2..0959250a3 100644 +index c7df33829..306009d96 100644 @@ -23 +24 @@ -@@ -1068,4 +1068,9 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, +@@ -688,4 +688,9 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,