From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3CB9A04F0 for ; Tue, 10 Dec 2019 16:00:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB5ED1BE80; Tue, 10 Dec 2019 16:00:59 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id F0C6E1B9B5 for ; Tue, 10 Dec 2019 16:00:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7UCRLMnvgQjbazVnIm1gPleGQnTD7sJiuphwsHs2vQE=; b=TV4BKjPRUbR3jl+jmBH5lkiLIjtIq/q0/H6WzKAV5iGzr+UPslNWvRETZQUjZQdEPpqDYa ykhvff41HL5L9eHOcpSs4IXpcxYj2JxVAaj7iLzpEqcAHa6U+Tztb5YkItTqYaKavhb9f0 kwOGxECgJshj4DnKKHsdTgCwk5xiOBQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-231-jLrv8FqQPQmWj-kheHUILQ-1; Tue, 10 Dec 2019 10:00:53 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9F5F1883528; Tue, 10 Dec 2019 15:00:52 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id D41895D9C5; Tue, 10 Dec 2019 15:00:51 +0000 (UTC) From: Kevin Traynor To: Peng Huang Cc: Bernard Iremonger , dpdk stable Date: Tue, 10 Dec 2019 14:59:07 +0000 Message-Id: <20191210145937.32755-33-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: jLrv8FqQPQmWj-kheHUILQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: fix Tx checksum when TSO enabled' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/f537973165b0348d85= f79ce0be6be63fb17ad8e8 Thanks. Kevin. --- >From f537973165b0348d85f79ce0be6be63fb17ad8e8 Mon Sep 17 00:00:00 2001 From: Peng Huang Date: Thu, 24 Oct 2019 09:37:34 +0000 Subject: [PATCH] app/testpmd: fix Tx checksum when TSO enabled [ upstream commit 0322272c9fd39e1a5942c73232d43d3ebeeff7b1 ] This patch fixed the TX checksum value problem when enabled TSO in tunnel packets, because outer UDP checksum calculation depend on the TSO configuration. Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine"= ) Signed-off-by: Peng Huang Acked-by: Bernard Iremonger --- app/test-pmd/csumonly.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index f4f2a7b29..46eb52d5b 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -473,4 +473,7 @@ process_outer_cksums(void *outer_l3_hdr, struct testpmd= _offload_info *info, =09=09return ol_flags; =20 +=09if (tso_enabled) +=09=09ol_flags |=3D PKT_TX_TCP_SEG; + =09/* Skip SW outer UDP checksum generation if HW supports it */ =09if (tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) { --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:41.341066254 +0000 +++ 0033-app-testpmd-fix-Tx-checksum-when-TSO-enabled.patch=092019-12-10 14= :49:39.048457842 +0000 @@ -1 +1 @@ -From 0322272c9fd39e1a5942c73232d43d3ebeeff7b1 Mon Sep 17 00:00:00 2001 +From f537973165b0348d85f79ce0be6be63fb17ad8e8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0322272c9fd39e1a5942c73232d43d3ebeeff7b1 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index e12695d94..5738128e6 100644 +index f4f2a7b29..46eb52d5b 100644 @@ -23,2 +24,2 @@ -@@ -545,4 +545,7 @@ process_outer_cksums(void *outer_l3_hdr, struct testpm= d_offload_info *info, - =09=09((char *)outer_l3_hdr + info->outer_l3_len); +@@ -473,4 +473,7 @@ process_outer_cksums(void *outer_l3_hdr, struct testpm= d_offload_info *info, + =09=09return ol_flags;