From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98562A04F1 for ; Tue, 10 Dec 2019 16:01:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 777F41BF31; Tue, 10 Dec 2019 16:01:15 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 460E41B13C for ; Tue, 10 Dec 2019 16:01:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0F0jzEMe43q1GhcI7GXl9R7nCcB56dDfQ/EOJXLLw9Y=; b=c7DWmVnqOh6gEPeDmROXvop/5lTBn7lVkD6cwrCYCKbwncg6c/ff9dUemCKHOJ/7iR0+le FiVzCAT6fWrN3iwJIqdYAbbp0/KUDbj9BkOK5y6Yk+UTmJcU026xjKOpKF4gf6WQBgAEhx fYX1zJJv1BX6vuG9DoCV9eBbYHgE7Ws= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-kWBU_JeFN5izvniADjbegg-1; Tue, 10 Dec 2019 10:01:10 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07783107ACC7; Tue, 10 Dec 2019 15:01:09 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8ADA45D9C5; Tue, 10 Dec 2019 15:01:07 +0000 (UTC) From: Kevin Traynor To: Xiao Zhang Cc: Marvin Liu , David Hunt , dpdk stable Date: Tue, 10 Dec 2019 14:59:16 +0000 Message-Id: <20191210145937.32755-42-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: kWBU_JeFN5izvniADjbegg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'examples/l3fwd-power: fix Rx interrupt disabling' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fbf65ffa07f781f3d5= 90e2ed3ae1d6a3dfdd2143 Thanks. Kevin. --- >From fbf65ffa07f781f3d590e2ed3ae1d6a3dfdd2143 Mon Sep 17 00:00:00 2001 From: Xiao Zhang Date: Wed, 11 Sep 2019 00:10:14 +0800 Subject: [PATCH] examples/l3fwd-power: fix Rx interrupt disabling [ upstream commit 0412cfeff907bb9102a2ca834e95ef8c6767f538 ] Interrupt will not be received when disabling RX interrupt without synchronization mechanism sometimes which leads to wake up issue. Add spinlock to fix it. Fixes: b736d64787 ("examples/l3fwd-power: disable Rx interrupt when waking = up") Signed-off-by: Xiao Zhang Reviewed-by: Marvin Liu Acked-by: David Hunt --- examples/l3fwd-power/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 3421de8ec..ec06129c1 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -815,5 +815,7 @@ sleep_until_rx_interrupt(int num) =09=09queue_id =3D ((uintptr_t)data) & =09=09=09RTE_LEN2MASK(CHAR_BIT, uint8_t); +=09=09rte_spinlock_lock(&(locks[port_id])); =09=09rte_eth_dev_rx_intr_disable(port_id, queue_id); +=09=09rte_spinlock_unlock(&(locks[port_id])); =09=09RTE_LOG(INFO, L3FWD_POWER, =09=09=09"lcore %u is waked up from rx interrupt on" --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:41.906673061 +0000 +++ 0042-examples-l3fwd-power-fix-Rx-interrupt-disabling.patch=092019-12-10= 14:49:39.074457357 +0000 @@ -1 +1 @@ -From 0412cfeff907bb9102a2ca834e95ef8c6767f538 Mon Sep 17 00:00:00 2001 +From fbf65ffa07f781f3d590e2ed3ae1d6a3dfdd2143 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0412cfeff907bb9102a2ca834e95ef8c6767f538 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index a03f64a1a..d049d8a5d 100644 +index 3421de8ec..ec06129c1 100644 @@ -24 +25 @@ -@@ -881,5 +881,7 @@ sleep_until_rx_interrupt(int num) +@@ -815,5 +815,7 @@ sleep_until_rx_interrupt(int num)