From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34A8DA04F0 for ; Tue, 10 Dec 2019 16:01:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D7B51B13C; Tue, 10 Dec 2019 16:01:30 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5FB0B1BE80 for ; Tue, 10 Dec 2019 16:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9iOY6Y2LSYpP4Nz2P4wA1eGOhuCGc1rerxK8p8HzLpE=; b=dZKrobx5tHZT1Z0o6zkgO3dKfqgYt3HENA6XHYjBj+cb06G7pHdcDmTiieFn0QyzLMh5VH fTfFyP83L9D7Lb9KXRrLmmpmYK5vr9561EilGfFdUYC+GK36+o4R6SYaXb0J/KTUucADP2 35Yq8sbSFzVQqYaGVdu9HNh4bgjlBdI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-yShuyquoNtmDHbx61Vn2Ng-1; Tue, 10 Dec 2019 10:01:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91525107ACCA; Tue, 10 Dec 2019 15:01:22 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9165B5DA2C; Tue, 10 Dec 2019 15:01:21 +0000 (UTC) From: Kevin Traynor To: Andrzej Ostruszka Cc: Jerin Jacob , dpdk stable Date: Tue, 10 Dec 2019 14:59:24 +0000 Message-Id: <20191210145937.32755-50-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: yShuyquoNtmDHbx61Vn2Ng-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'eventdev: fix possible use of uninitialized var' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/36050598d20a44fb94= 36a49ad558d398af71058b Thanks. Kevin. --- >From 36050598d20a44fb9436a49ad558d398af71058b Mon Sep 17 00:00:00 2001 From: Andrzej Ostruszka Date: Thu, 7 Nov 2019 16:03:10 +0100 Subject: [PATCH] eventdev: fix possible use of uninitialized var MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 57e20572ac67a55874a206ef7339443b0950705d ] Fix the logic for the case of event queue allowing all schedule types. Compiler warning pointing to this error (with LTO enabled): error: =E2=80=98sched_type=E2=80=99 may be used uninitialized in this funct= ion [-Werror=3Dmaybe-uninitialized] if ((ret < 0 && ret !=3D -EOVERFLOW) || Fixes: 6750b21bd6af ("eventdev: add default software timer adapter") Signed-off-by: Andrzej Ostruszka Reviewed-by: Jerin Jacob --- lib/librte_eventdev/rte_event_timer_adapter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eve= ntdev/rte_event_timer_adapter.c index 026d639bc..7226fc624 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.c +++ b/lib/librte_eventdev/rte_event_timer_adapter.c @@ -685,9 +685,9 @@ check_destination_event_queue(struct rte_event_timer *e= vtim, =09=09=09=09 &sched_type); =20 -=09if ((ret < 0 && ret !=3D -EOVERFLOW) || -=09 evtim->ev.sched_type !=3D sched_type) -=09=09return -1; +=09if ((ret =3D=3D 0 && evtim->ev.sched_type =3D=3D sched_type) || +=09 ret =3D=3D -EOVERFLOW) +=09=09return 0; =20 -=09return 0; +=09return -1; } =20 --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:42.395867983 +0000 +++ 0050-eventdev-fix-possible-use-of-uninitialized-var.patch=092019-12-10 = 14:49:39.083457189 +0000 @@ -1 +1 @@ -From 57e20572ac67a55874a206ef7339443b0950705d Mon Sep 17 00:00:00 2001 +From 36050598d20a44fb9436a49ad558d398af71058b Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 57e20572ac67a55874a206ef7339443b0950705d ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 5ce399eca..161e21a68 100644 +index 026d639bc..7226fc624 100644 @@ -29 +30 @@ -@@ -707,9 +707,9 @@ check_destination_event_queue(struct rte_event_timer *= evtim, +@@ -685,9 +685,9 @@ check_destination_event_queue(struct rte_event_timer *= evtim,