From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D78AA04F0 for ; Tue, 10 Dec 2019 16:00:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 076B41BEC4; Tue, 10 Dec 2019 16:00:17 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 3B0741BE9D for ; Tue, 10 Dec 2019 16:00:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575990015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eeiiYy4QYzXEBMWEKgNMV/qMZo1hNOtj0sqZwoAo15k=; b=X2AG99xpyyWCvWOXiw5IjEmuU6kHtUoNKtTfmdYo771uPhGZuYQH80agwMY9+ECrEeW4fW 8lEUPs2ogtLuUhNJvRJYjz67v3aaGIY8IPxtc++gu4Bb+H99dL1neNtBSZt5iaHSAk+I5K nLg+XwIFU82ouKXSiP9ftc90C6Qtrxo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-45BS8qWLOZmx_XPbeGs4OA-1; Tue, 10 Dec 2019 10:00:12 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1376F800D5F; Tue, 10 Dec 2019 15:00:11 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id D97175DA2C; Tue, 10 Dec 2019 15:00:09 +0000 (UTC) From: Kevin Traynor To: Joyce Kong Cc: Xiao Zhang , Xiaolong Ye , dpdk stable Date: Tue, 10 Dec 2019 14:58:41 +0000 Message-Id: <20191210145937.32755-7-ktraynor@redhat.com> In-Reply-To: <20191210145937.32755-1-ktraynor@redhat.com> References: <20191210145937.32755-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 45BS8qWLOZmx_XPbeGs4OA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/ixgbe: fix address of first segment' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/16/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/b7626d6aa7ebf906c6= a437d6d3a58e45b2c449b8 Thanks. Kevin. --- >From b7626d6aa7ebf906c6a437d6d3a58e45b2c449b8 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Tue, 24 Sep 2019 13:48:45 +0800 Subject: [PATCH] net/ixgbe: fix address of first segment [ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ] This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 13245 Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector = driver") Signed-off-by: Joyce Kong Reviewed-by: Xiao Zhang Reviewed-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ix= gbe_rxtx_vec_neon.c index 86fb3afdb..07f2fafe7 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c @@ -375,4 +375,5 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rt= e_mbuf **rx_pkts, =09=09if (i =3D=3D nb_bufs) =09=09=09return nb_bufs; +=09=09rxq->pkt_first_seg =3D rx_pkts[i]; =09} =09return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i, --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-10 14:49:39.570070793 +0000 +++ 0007-net-ixgbe-fix-address-of-first-segment.patch=092019-12-10 14:49:38= .990458924 +0000 @@ -1 +1 @@ -From 648255d43e4a820274cbb02cca3ece445d8de302 Mon Sep 17 00:00:00 2001 +From b7626d6aa7ebf906c6a437d6d3a58e45b2c449b8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 648255d43e4a820274cbb02cca3ece445d8de302 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index eeb825911..26c0ef5ae 100644 +index 86fb3afdb..07f2fafe7 100644 @@ -25 +26 @@ -@@ -376,4 +376,5 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct r= te_mbuf **rx_pkts, +@@ -375,4 +375,5 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct r= te_mbuf **rx_pkts,