From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07B47A04F5 for ; Wed, 11 Dec 2019 22:27:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E01C91D9E; Wed, 11 Dec 2019 22:27:32 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 5B8AA1D9E for ; Wed, 11 Dec 2019 22:27:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=STN32fS5W5hgAK5RhchOli8dmOUHMxHADLXadyglHxY=; b=YPautN96gGjLEwl9h6itPnCzvLbIOtRpKEtz/yuL2hSxO8zah8tI5af/ZZk5ynpBI+zI1E LNo3aEAfEI7mhIc3mqbbNSBr0y3K8lU4vITSArV3NrDKd9I/DGoslZCF0cXLsJBg69py+e +rTvk4O+FnYpoGeSdqpWDnFYI680J3o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-8Jl6uJzXOrahxTxrlKlXWw-1; Wed, 11 Dec 2019 16:27:28 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3097800D4E; Wed, 11 Dec 2019 21:27:26 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id C298510013A1; Wed, 11 Dec 2019 21:27:25 +0000 (UTC) From: Kevin Traynor To: Shahed Shaikh Cc: Rasesh Mody , dpdk stable Date: Wed, 11 Dec 2019 21:25:53 +0000 Message-Id: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 8Jl6uJzXOrahxTxrlKlXWw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/qede: fix setting MTU' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/9e72106d516ab1d4c5= 372ef71afb1c0398dfeba5 Thanks. Kevin. --- >From 9e72106d516ab1d4c5372ef71afb1c0398dfeba5 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Sat, 19 Oct 2019 22:20:50 -0700 Subject: [PATCH] net/qede: fix setting MTU [ upstream commit 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe ] New MTU value is not propagated to vport in HW when MTU update request is sent while ports are stopped. This patch fixes the logic error for above mentioned condition. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Shahed Shaikh Reviewed-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 8 +++++--- drivers/net/qede/qede_ethdev.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.= c index 97d991cad..acb61cc21 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1021,7 +1021,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev= ) =20 =09/* Update MTU only if it has changed */ -=09if (eth_dev->data->mtu !=3D qdev->mtu) { -=09=09if (qede_update_mtu(eth_dev, qdev->mtu)) +=09if (qdev->new_mtu && qdev->new_mtu !=3D qdev->mtu) { +=09=09if (qede_update_mtu(eth_dev, qdev->new_mtu)) =09=09=09goto err; +=09=09qdev->mtu =3D qdev->new_mtu; +=09=09qdev->new_mtu =3D 0; =09} =20 @@ -2207,5 +2209,5 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint= 16_t mtu) =09} =09rte_delay_ms(1000); -=09qdev->mtu =3D mtu; +=09qdev->new_mtu =3D mtu; =20 =09/* Fix up RX buf size for all queues of the port */ diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.= h index 735dfdb66..1a426cf00 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethdev.h @@ -218,4 +218,5 @@ struct qede_dev { =09struct qede_fastpath_cmt *fp_array_cmt; =09uint16_t mtu; +=09uint16_t new_mtu; =09bool enable_tx_switching; =09bool rss_enable; --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-11 21:24:12.810348176 +0000 +++ 0001-net-qede-fix-setting-MTU.patch=092019-12-11 21:24:12.506654545 +00= 00 @@ -1 +1 @@ -From 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe Mon Sep 17 00:00:00 2001 +From 9e72106d516ab1d4c5372ef71afb1c0398dfeba5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 53fdfde9a..42e2b5083 100644 +index 97d991cad..acb61cc21 100644 @@ -25 +26 @@ -@@ -1039,7 +1039,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_de= v) +@@ -1021,7 +1021,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_de= v) @@ -37 +38 @@ -@@ -2249,5 +2251,5 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uin= t16_t mtu) +@@ -2207,5 +2209,5 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uin= t16_t mtu) @@ -45 +46 @@ -index 21115a077..b988a73f2 100644 +index 735dfdb66..1a426cf00 100644 @@ -48 +49 @@ -@@ -226,4 +226,5 @@ struct qede_dev { +@@ -218,4 +218,5 @@ struct qede_dev {