From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A429AA04F5 for ; Wed, 11 Dec 2019 22:28:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BEA834EF; Wed, 11 Dec 2019 22:28:13 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 271522C6A for ; Wed, 11 Dec 2019 22:28:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGPudEveExfCsYglJiPis9Rm8CwPfF/AKLGkgjW3x4I=; b=dcjqVGvNvRD32htGl3TGVT2cQuttbDS/pwJ6Cay/V+L82JIl0KqeSyaAE+HqEiHEg/NHtI adwmdKnwymG5Hl5DXmFIhjpZul/A8gKsUwvleRg/whbo0XPf3CYMa/635Lef4iLpx2CnE/ ShoHr1UiNsr7qFPrDxCHJmHl3Z6vBDs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-Ft-Rdt9-Om6cr1cL1MPdAw-1; Wed, 11 Dec 2019 16:28:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2B59DBF7; Wed, 11 Dec 2019 21:28:08 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DAC1A10013A1; Wed, 11 Dec 2019 21:28:07 +0000 (UTC) From: Kevin Traynor To: Hyong Youb Kim Cc: John Daley , dpdk stable Date: Wed, 11 Dec 2019 21:26:11 +0000 Message-Id: <20191211212702.27851-19-ktraynor@redhat.com> In-Reply-To: <20191211212702.27851-1-ktraynor@redhat.com> References: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Ft-Rdt9-Om6cr1cL1MPdAw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/enic: re-enable link status change interrupt' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/759a205e118e731dc5= e3cb209f3716fd4f8a45d3 Thanks. Kevin. --- >From 759a205e118e731dc5e3cb209f3716fd4f8a45d3 Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Thu, 7 Nov 2019 06:42:24 -0800 Subject: [PATCH] net/enic: re-enable link status change interrupt [ upstream commit 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 ] When INTx is used, the interrupt handler needs to explicitly re-enable interrupt in order to receive another one in future. The LSC interrupt handler currently does not, and the link state never gets updated when INTx is used (e.g. uio_pci_generic). Call rte_intr_ack() at the end of the handler, to re-enable INTx. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/Makefile | 2 ++ drivers/net/enic/enic_main.c | 2 ++ drivers/net/enic/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile index e39e47631..a101d0fe0 100644 --- a/drivers/net/enic/Makefile +++ b/drivers/net/enic/Makefile @@ -14,4 +14,6 @@ EXPORT_MAP :=3D rte_pmd_enic_version.map LIBABIVER :=3D 1 =20 +# Experimental APIs used: rte_intr_ack +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API CFLAGS +=3D -I$(SRCDIR)/base/ CFLAGS +=3D -I$(SRCDIR) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index c3dc3dee1..6b3b0867d 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -442,4 +442,6 @@ enic_intr_handler(void *arg) =09_rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); =09enic_log_q_error(enic); +=09/* Re-enable irq in case of INTx */ +=09rte_intr_ack(&enic->pdev->intr_handle); } =20 diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build index 9e9a567ae..4a4d2d654 100644 --- a/drivers/net/enic/meson.build +++ b/drivers/net/enic/meson.build @@ -2,4 +2,6 @@ # Copyright(c) 2018 Cisco Systems, Inc. =20 +# Experimental APIs used: rte_intr_ack +cflags +=3D ['-DALLOW_EXPERIMENTAL_API'] sources =3D files( =09'base/vnic_cq.c', --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-11 21:24:14.253917793 +0000 +++ 0019-net-enic-re-enable-link-status-change-interrupt.patch=092019-12-11= 21:24:12.610652395 +0000 @@ -1 +1 @@ -From 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 Mon Sep 17 00:00:00 2001 +From 759a205e118e731dc5e3cb209f3716fd4f8a45d3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 10736a567..4e0c83da5 100644 +index e39e47631..a101d0fe0 100644 @@ -35 +36 @@ -index f5b9b0dcb..57574a5f7 100644 +index c3dc3dee1..6b3b0867d 100644 @@ -38 +39 @@ -@@ -449,4 +449,6 @@ enic_intr_handler(void *arg) +@@ -442,4 +442,6 @@ enic_intr_handler(void *arg) @@ -46 +47 @@ -index 1bd7cc7e1..e5eeb5667 100644 +index 9e9a567ae..4a4d2d654 100644