From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 218E1A04F5 for ; Wed, 11 Dec 2019 22:28:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05E501BE80; Wed, 11 Dec 2019 22:28:56 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5BB0E1D9E for ; Wed, 11 Dec 2019 22:28:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCvhtkUsuONzv03TKeD21fm3A9aR9QpoFRZTQf/Mm7w=; b=NhCZ2gHyo/W190mXgsFjYWX68GilWiy33aOn+/85eXnB7iG/sPvWC5K11pgIdy+1cwAAkI ZEt0aKbI16jVaQnb7n8qfGHu5Z4ACP7d6UHt+BTHPDAhy43tIfcWLPGQvzgCGUuP4p3V49 qxgJsXXMzhqnYG+WudZiLU7Jk+s4eqc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-WmTQ49zDNT2OtMpnisuzQA-1; Wed, 11 Dec 2019 16:28:53 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70B97DBE5; Wed, 11 Dec 2019 21:28:52 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6348110013A1; Wed, 11 Dec 2019 21:28:51 +0000 (UTC) From: Kevin Traynor To: Matan Azrad Cc: Bernard Iremonger , dpdk stable Date: Wed, 11 Dec 2019 21:26:37 +0000 Message-Id: <20191211212702.27851-45-ktraynor@redhat.com> In-Reply-To: <20191211212702.27851-1-ktraynor@redhat.com> References: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: WmTQ49zDNT2OtMpnisuzQA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: fix invalid port detaching' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/df025f644116d26700= 756b3cc5381b33a305f31a Thanks. Kevin. --- >From df025f644116d26700756b3cc5381b33a305f31a Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Tue, 12 Nov 2019 08:47:39 +0000 Subject: [PATCH] app/testpmd: fix invalid port detaching [ upstream commit 43d0e304980a1527bcac92dc679057b189e2545a ] The port was not validated before detaching. Ignore port detach operation when the port is not valid. Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice") Signed-off-by: Matan Azrad Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 81f6d4f96..98fe2f8f7 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2351,4 +2351,7 @@ detach_port_device(portid_t port_id) =09printf("Removing a device...\n"); =20 +=09if (port_id_is_invalid(port_id, ENABLED_WARN)) +=09=09return; + =09dev =3D rte_eth_devices[port_id].device; =09if (dev =3D=3D NULL) { --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-11 21:24:16.282476537 +0000 +++ 0045-app-testpmd-fix-invalid-port-detaching.patch=092019-12-11 21:24:12= .704650453 +0000 @@ -1 +1 @@ -From 43d0e304980a1527bcac92dc679057b189e2545a Mon Sep 17 00:00:00 2001 +From df025f644116d26700756b3cc5381b33a305f31a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 43d0e304980a1527bcac92dc679057b189e2545a ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 446da3623..73ebf37aa 100644 +index 81f6d4f96..98fe2f8f7 100644 @@ -23 +24 @@ -@@ -2558,4 +2558,7 @@ detach_port_device(portid_t port_id) +@@ -2351,4 +2351,7 @@ detach_port_device(portid_t port_id)