From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DED09A04F5 for ; Wed, 11 Dec 2019 22:29:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEFBC1B994; Wed, 11 Dec 2019 22:29:05 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 368B01B994 for ; Wed, 11 Dec 2019 22:29:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qJinCIGhJvVyKVyzBo3GcSx7ZcshJ13NFbidWmuYWzw=; b=ZQryEtCZewi5u5DEbH1JARXGgkL4PVu2tQJyQ3YS5wtr7HCepRfVWGBKc06LQ0TXkYtpN/ va9s43ux1evZ+bc1bXV9GRvv+t9t2iCwf8Vu7/eLG32ATZNEHmp5/HhFCkJm1CAy27ztpr pLhndZHSWtpyn3X63rXJzmLmVlWeqBo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-GVStNpK6OfmkwyOTw3uQXA-1; Wed, 11 Dec 2019 16:29:01 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D852800EC0; Wed, 11 Dec 2019 21:29:00 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83A6110013A1; Wed, 11 Dec 2019 21:28:59 +0000 (UTC) From: Kevin Traynor To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Wed, 11 Dec 2019 21:26:43 +0000 Message-Id: <20191211212702.27851-51-ktraynor@redhat.com> In-Reply-To: <20191211212702.27851-1-ktraynor@redhat.com> References: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: GVStNpK6OfmkwyOTw3uQXA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/eventdev: check function errors' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/f34a476df925db301d= f9f74e2b5007392b09ae8a Thanks. Kevin. --- >From f34a476df925db301df9f74e2b5007392b09ae8a Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Fri, 22 Nov 2019 00:52:39 +0530 Subject: [PATCH] app/eventdev: check function errors [ upstream commit a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd ] Fix unchecked return values reported by coverity. Coverity Issue: 336861 Coverity Issue: 349906 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/t= est_pipeline_common.c index 5db3ffde1..c988da28c 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -160,4 +160,5 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt= _options *opt) { =09uint16_t i; +=09int ret; =09uint8_t nb_queues =3D 1; =09struct test_pipeline *t =3D evt_test_priv(test); @@ -188,5 +189,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct ev= t_options *opt) =09=09uint32_t caps =3D 0; =20 -=09=09rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps); +=09=09ret =3D rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps); +=09=09if (ret !=3D 0) { +=09=09=09evt_err("failed to get event tx adapter[%d] caps", i); +=09=09=09return ret; +=09=09} + =09=09if (!(caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) =09=09=09t->internal_port =3D 0; --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-11 21:24:16.718999362 +0000 +++ 0051-app-eventdev-check-function-errors.patch=092019-12-11 21:24:12.710= 650329 +0000 @@ -1 +1 @@ -From a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd Mon Sep 17 00:00:00 2001 +From f34a476df925db301df9f74e2b5007392b09ae8a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a8d88bfbce00b6f3b1e4c4a3a4464954a21372dd ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16,2 +17,2 @@ - app/test-eventdev/test_pipeline_common.c | 17 ++++++++++++++--- - 1 file changed, 14 insertions(+), 3 deletions(-) + app/test-eventdev/test_pipeline_common.c | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) @@ -20 +21 @@ -index 160461fb2..fa91bf229 100644 +index 5db3ffde1..c988da28c 100644 @@ -23 +24,7 @@ -@@ -197,5 +197,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct e= vt_options *opt) +@@ -160,4 +160,5 @@ pipeline_ethdev_setup(struct evt_test *test, struct ev= t_options *opt) + { + =09uint16_t i; ++=09int ret; + =09uint8_t nb_queues =3D 1; + =09struct test_pipeline *t =3D evt_test_priv(test); +@@ -188,5 +189,10 @@ pipeline_ethdev_setup(struct evt_test *test, struct e= vt_options *opt) @@ -35,20 +41,0 @@ -@@ -425,5 +430,5 @@ pipeline_mempool_setup(struct evt_test *test, struct e= vt_options *opt) - { - =09struct test_pipeline *t =3D evt_test_priv(test); --=09int i; -+=09int i, ret; -=20 - =09if (!opt->mbuf_sz) -@@ -438,5 +443,11 @@ pipeline_mempool_setup(struct evt_test *test, struct = evt_options *opt) -=20 - =09=09memset(&dev_info, 0, sizeof(dev_info)); --=09=09rte_eth_dev_info_get(i, &dev_info); -+=09=09ret =3D rte_eth_dev_info_get(i, &dev_info); -+=09=09if (ret !=3D 0) { -+=09=09=09evt_err("Error during getting device (port %u) info: %s\n", -+=09=09=09=09i, strerror(-ret)); -+=09=09=09return ret; -+=09=09} -+ - =09=09if (dev_info.rx_desc_lim.nb_mtu_seg_max !=3D UINT16_MAX && - =09=09=09=09dev_info.rx_desc_lim.nb_mtu_seg_max !=3D 0) {