From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 986E2A04F5 for ; Wed, 11 Dec 2019 22:29:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78C321BF71; Wed, 11 Dec 2019 22:29:33 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 25F621F5 for ; Wed, 11 Dec 2019 22:29:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576099771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6JOyF8Lq3q+8xRw4DWA7JIJsfFVohpXZkdJ6W2MBwe8=; b=KluH+6Y9w8yX7/SNrSF2o3fa2znt1VHR03UMnj6XD9RX56QuseY39IBXf/7O8yBSJvcYPi L/8xB8I0jx7DR++syO2TTuPKWgSh8HVF6PyoFI+A8h65rSTo++0bbpT8nF+nm2+rMdiH5q blYqS5Zese1j4bzaUZWXsknLBgXmhtc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-8qI_Fh9yMAKrP-cQg08XWQ-1; Wed, 11 Dec 2019 16:29:29 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C80BC801E70; Wed, 11 Dec 2019 21:29:28 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-64.ams2.redhat.com [10.36.116.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 548ED10013A1; Wed, 11 Dec 2019 21:29:27 +0000 (UTC) From: Kevin Traynor To: Harry van Haaren Cc: Aaron Conole , David Marchand , dpdk stable Date: Wed, 11 Dec 2019 21:27:00 +0000 Message-Id: <20191211212702.27851-68-ktraynor@redhat.com> In-Reply-To: <20191211212702.27851-1-ktraynor@redhat.com> References: <20191211212702.27851-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: 8qI_Fh9yMAKrP-cQg08XWQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'test/service: fix wait for service core' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/17/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/3fd8e91785e8b7f821= eb46925397466608e10ef8 Thanks. Kevin. --- >From 3fd8e91785e8b7f821eb46925397466608e10ef8 Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Wed, 27 Nov 2019 13:20:27 +0000 Subject: [PATCH] test/service: fix wait for service core [ upstream commit 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b ] This commit fixes a sporadic failure of the service_autotest unit test, as seen in the DPDK CI. The failure occurs as the main test thread did not wait on the service-thread to return, and allowing it to read a flag before the service was able to write to it. The fix changes the wait API call to specific the service-core ID, and this waits for cores with both ROLE_RTE and ROLE_SERVICE. The rte_eal_mp_wait_lcore() call does not (and should not) wait for service cores, so must not be used to wait on service-cores. Fixes: f038a81e1c56 ("service: add unit tests") Reported-by: Aaron Conole Signed-off-by: Harry van Haaren Acked-by: David Marchand --- test/test/test_service_cores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores.= c index ec31882d9..aa2174a33 100644 --- a/test/test/test_service_cores.c +++ b/test/test/test_service_cores.c @@ -484,5 +484,5 @@ service_lcore_en_dis_able(void) =09=09=09=09=09slcore_id); =09TEST_ASSERT_EQUAL(0, ret, "Ex-service core remote launch failed."); -=09rte_eal_mp_wait_lcore(); +=09rte_eal_wait_lcore(slcore_id); =09TEST_ASSERT_EQUAL(1, service_remote_launch_flag, =09=09=09"Ex-service core function call had no effect."); --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-12-11 21:24:17.985987757 +0000 +++ 0068-test-service-fix-wait-for-service-core.patch=092019-12-11 21:24:12= .756649378 +0000 @@ -1 +1 @@ -From 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b Mon Sep 17 00:00:00 2001 +From 3fd8e91785e8b7f821eb46925397466608e10ef8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 505a2b0c64a7f1e087f5a8aaa6940da78c11c81b ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ - app/test/test_service_cores.c | 2 +- + test/test/test_service_cores.c | 2 +- @@ -27,4 +28,4 @@ -diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c -index 9fe38f5e0..a922c7ddc 100644 ---- a/app/test/test_service_cores.c -+++ b/app/test/test_service_cores.c +diff --git a/test/test/test_service_cores.c b/test/test/test_service_cores= .c +index ec31882d9..aa2174a33 100644 +--- a/test/test/test_service_cores.c ++++ b/test/test/test_service_cores.c