From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE23BA0500 for ; Tue, 17 Dec 2019 19:07:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A684B1BF6F; Tue, 17 Dec 2019 19:07:02 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 6A3C81BF31 for ; Tue, 17 Dec 2019 19:07:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576606020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=My0evXWGwzNn+tbXUPkHrs0PmS4q6t7pMb+S1vNlLts=; b=hoiAqTiBZem3BJgNr7okPr4oeZQuTE1fNUQpWoaWnc4gF4hQmPs9xN0D9b8sEoK0KBz8GN a6GjpN+DrV3Bys9w3QqJdnBW9BjVJOQz4HfOBD3BMUCWKTaMaDZuDbGm3AivBhbGvYORuP yo+0sR7m9S9FdYg+IF9lY+XGh/laCJw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-uCa0icgdMtGRuxO8KgeenA-1; Tue, 17 Dec 2019 13:06:59 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6ECB710054E3; Tue, 17 Dec 2019 18:06:58 +0000 (UTC) Received: from amorenoz.users.ipa.redhat.com (ovpn-117-34.ams2.redhat.com [10.36.117.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id 294737C839; Tue, 17 Dec 2019 18:06:56 +0000 (UTC) From: Adrian Moreno To: stable@dpdk.org Cc: ktraynor@redhat.com, maxime.coquelin@redhat.com, Tiwei Bie Date: Tue, 17 Dec 2019 19:06:36 +0100 Message-Id: <20191217180640.17993-4-amorenoz@redhat.com> In-Reply-To: <20191217180640.17993-1-amorenoz@redhat.com> References: <20191217180640.17993-1-amorenoz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: uCa0icgdMtGRuxO8KgeenA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] [PATCH 18.11 3/7] vhost: do not inline packed and split functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: Maxime Coquelin [ upstream commit 5a5f6e78b24881941a75d6b9f1214f0ee0e2f9aa] At runtime either packed Tx/Rx functions will always be called, or split Tx/Rx functions will always be called. This patch removes the forced inlining in order to reduce the I-cache pressure. Signed-off-by: Maxime Coquelin Reviewed-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 6ae617698..26601c2d4 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -811,7 +811,7 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_= virtqueue *vq, =09return error; } =20 -static __rte_always_inline uint32_t +static __rte_noinline uint32_t virtio_dev_rx_split(struct virtio_net *dev, struct vhost_virtqueue *vq, =09struct rte_mbuf **pkts, uint32_t count) { @@ -869,7 +869,7 @@ virtio_dev_rx_split(struct virtio_net *dev, struct vhos= t_virtqueue *vq, =09return pkt_idx; } =20 -static __rte_always_inline uint32_t +static __rte_noinline uint32_t virtio_dev_rx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, =09struct rte_mbuf **pkts, uint32_t count) { @@ -1339,7 +1339,7 @@ get_zmbuf(struct vhost_virtqueue *vq) =09return NULL; } =20 -static __rte_always_inline uint16_t +static __rte_noinline uint16_t virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq, =09struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, uint16_t count) { @@ -1461,7 +1461,7 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vh= ost_virtqueue *vq, =09return i; } =20 -static __rte_always_inline uint16_t +static __rte_noinline uint16_t virtio_dev_tx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq, =09struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, uint16_t count) { --=20 2.21.0