From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE5B6A04F0 for ; Thu, 19 Dec 2019 15:40:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC93B1BFD5; Thu, 19 Dec 2019 15:40:45 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 89F751BFFB for ; Thu, 19 Dec 2019 15:40:44 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id a5so5685251wmb.0 for ; Thu, 19 Dec 2019 06:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Afy/tp/Rd4YLx5VB9c0y5mTgA5YMg2WlZ1KQwq0rKjI=; b=hsJONDrPFz8NcYhdqRMe4hLt+qQzx7p2e94Co3w0bcpUtC5lbg/9jdl++lKMVqfq35 QfRgSknIIMovuLhEka7Y+rX4KK+v46bYO8iZbKbXvGy4NUfxmLlNrn3z6FCkz46/27EV 17lbgQvQmBNnlN2DZBMTCrTaV1djetZ8mDPvsjZtTHYKyi7JuQJDD+NoEVIuHiz3nWWV 8FJbikXWbnQAygY4izyUi2AXpTp5HD+1k5aPOU91+wuJRwwRtWVx7YsannmegTl3Uoyt ZWiOv3w6IsIcuOI+NS/G75ICjiyIgRIk4l5nUr2dWIJZLSTRIDtNH0id0ErZZTq0YLI0 gD8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Afy/tp/Rd4YLx5VB9c0y5mTgA5YMg2WlZ1KQwq0rKjI=; b=e2Jju/FtPte9LnZuBJ8PKyhorMvuis2Qrha30CgE+KwcQxCtjHS1Aq+BwDHdtkq33+ EhjCamzTTwoOXCF9LOES1x+RZyRa2IsuCY5ADvmnkxMGGY1SgMZ5D5cOO7KblpWQSsbj jQ+pZmJIJILAd99x2AZ+gf1S7SpKEEhPUeDtq0LZFRPBCUoMg4lBAVu89gZoqHIXYPRP /6NavnWWotZX2Ppzm5oVe7sNIvZGYa4ggXmSpSCo7jV4me6QMDlgLXrn8aLDFnO9OdeD IbHtJ7d3HgeHqV0hRVbELwTevzB9VnbTv958pC5UFywDSjtyx+DD4EYndu3cWd2dZc+u metw== X-Gm-Message-State: APjAAAWW43SJrhjZKs49snPcRXM7qfPA10HqCPqbDx+viawi7nxKBt/O Zsx1Ip625TBLWMCVjZYvuI8= X-Google-Smtp-Source: APXvYqwwESfmA4kFhVnXzi65Hbr5v1HeFUY5sor2XfqL/z3od4/lf4Q5Q5zI0mRnmAZUFMux3VsHxA== X-Received: by 2002:a1c:1bc3:: with SMTP id b186mr10469991wmb.79.1576766444059; Thu, 19 Dec 2019 06:40:44 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c68sm6356889wme.13.2019.12.19.06.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:40:43 -0800 (PST) From: luca.boccassi@gmail.com To: Shahed Shaikh Cc: Rasesh Mody , dpdk stable Date: Thu, 19 Dec 2019 14:34:17 +0000 Message-Id: <20191219143447.21506-110-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix setting MTU' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 5ddd68d7fbd2b6956f9d14b7652b69a7649faa07 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Sat, 19 Oct 2019 22:20:50 -0700 Subject: [PATCH] net/qede: fix setting MTU [ upstream commit 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe ] New MTU value is not propagated to vport in HW when MTU update request is sent while ports are stopped. This patch fixes the logic error for above mentioned condition. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Shahed Shaikh Reviewed-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 8 +++++--- drivers/net/qede/qede_ethdev.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 43403e6a8d..d5851a6513 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1178,9 +1178,11 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(edev); /* Update MTU only if it has changed */ - if (eth_dev->data->mtu != qdev->mtu) { - if (qede_update_mtu(eth_dev, qdev->mtu)) + if (qdev->new_mtu && qdev->new_mtu != qdev->mtu) { + if (qede_update_mtu(eth_dev, qdev->new_mtu)) goto err; + qdev->mtu = qdev->new_mtu; + qdev->new_mtu = 0; } /* Configure TPA parameters */ @@ -2408,7 +2410,7 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) restart = true; } rte_delay_ms(1000); - qdev->mtu = mtu; + qdev->new_mtu = mtu; /* Fix up RX buf size for all queues of the port */ for_each_rss(i) { diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index cc1a409f63..39d582296d 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethdev.h @@ -185,6 +185,7 @@ struct qede_dev { struct ecore_sb_info *sb_array; struct qede_fastpath *fp_array; uint16_t mtu; + uint16_t new_mtu; bool enable_tx_switching; bool rss_enable; struct rte_eth_rss_conf rss_conf; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:30.694790877 +0000 +++ 0110-net-qede-fix-setting-MTU.patch 2019-12-19 14:32:26.261300919 +0000 @@ -1,15 +1,16 @@ -From 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe Mon Sep 17 00:00:00 2001 +From 5ddd68d7fbd2b6956f9d14b7652b69a7649faa07 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Sat, 19 Oct 2019 22:20:50 -0700 Subject: [PATCH] net/qede: fix setting MTU +[ upstream commit 29bb154ff047d7fd7b0d4f08ce3ca25f1abfd1fe ] + New MTU value is not propagated to vport in HW when MTU update request is sent while ports are stopped. This patch fixes the logic error for above mentioned condition. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") -Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh Reviewed-by: Rasesh Mody @@ -19,10 +20,10 @@ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c -index 53fdfde9a8..42e2b50831 100644 +index 43403e6a8d..d5851a6513 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c -@@ -1038,9 +1038,11 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) +@@ -1178,9 +1178,11 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(edev); /* Update MTU only if it has changed */ @@ -36,7 +37,7 @@ } /* Configure TPA parameters */ -@@ -2248,7 +2250,7 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) +@@ -2408,7 +2410,7 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) restart = true; } rte_delay_ms(1000); @@ -44,14 +45,14 @@ + qdev->new_mtu = mtu; /* Fix up RX buf size for all queues of the port */ - for (i = 0; i < qdev->num_rx_queues; i++) { + for_each_rss(i) { diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h -index 21115a077e..b988a73f23 100644 +index cc1a409f63..39d582296d 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethdev.h -@@ -225,6 +225,7 @@ struct qede_dev { +@@ -185,6 +185,7 @@ struct qede_dev { + struct ecore_sb_info *sb_array; struct qede_fastpath *fp_array; - struct qede_fastpath_cmt *fp_array_cmt; uint16_t mtu; + uint16_t new_mtu; bool enable_tx_switching;