From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C020DA04F3 for ; Thu, 19 Dec 2019 15:35:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5A161BF70; Thu, 19 Dec 2019 15:35:58 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by dpdk.org (Postfix) with ESMTP id 625361BF70 for ; Thu, 19 Dec 2019 15:35:57 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id a5so5668434wmb.0 for ; Thu, 19 Dec 2019 06:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s2DMr6udEd1ESsF1PY73EdztObqdX4c8iAURJYc8i3I=; b=HNGgacfaZqBn5ThRxG+k5eketi7t1+3YReE2anzUlDywlsMWArZd8VTiforr7Yp9E7 SH7pNetcVcwKX7Ad6rxD0rt0vagJfTn+etwLIXTLt6WS8ZdL7leDK+qsrs37UoAkD+rv xG17QK3r66zXAYAwIj0tuHzBYqjVTXII61Hp0rZTpDkjAKHo+FqFhZEqAw1Jg5N6bSls HC1NWKrjqpcJg1ohvM6PebUbnFYPOQWFq5IFV7M0SthUQIWBf5oLT2MVlQtkPVHwAw18 Rt6HkFSl7KYAC9uJnqnTle2LLu2dnmWiYb3hM6B1SMrSlosiGIe10R9jICaVG9DRjL2r 4oqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s2DMr6udEd1ESsF1PY73EdztObqdX4c8iAURJYc8i3I=; b=fuwMBM3Cgbzy0Hb2lJ1+LHbOyKcvK/ygdLfURdxBN/GummPvdNf8q0CDW64S4/iNNf BxIRbdygPpwH7vXkuLGIl5xi0JmGGOXZvFyLpfYrZxvPMVcX6CRq0LbmSSfUyVpo65JG q5uyWt5Ax40UgrayJ01WkDt/fE/MmpXrdMVJKowaV4I5ZtY/xeRaa3X3D68QXWFYiSK8 V2aPzkjveipbSXOwiQu95LZYXunE4JGK1mnj5y4lYoE7Tp85nAq1+GbzyuQFn5MIIesT PwHny6SsvmjHRWKpAvLUlXCxJ8icYqNUchdLswlCBL3G4SpYHwyNk0ag6St5FD/FLODc /49g== X-Gm-Message-State: APjAAAUX6yykl7/gYHLc09mGraSHY5jfcXA0qmpsi0+uU+aoc++1Lg6Y wFlKF/jEexyxeU81sbmeasQ= X-Google-Smtp-Source: APXvYqzYIsZksyE7C+yLhbOiV5K9j8qh79Ib1TK6uTHKi/Aicr1ZhylzjK+SVJUa23Ma6GCq/okJgA== X-Received: by 2002:a1c:1bc3:: with SMTP id b186mr10442123wmb.79.1576766157093; Thu, 19 Dec 2019 06:35:57 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id f127sm5249808wma.4.2019.12.19.06.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:35:56 -0800 (PST) From: luca.boccassi@gmail.com To: Thierry Herbelot Cc: Akhil Goyal , dpdk stable Date: Thu, 19 Dec 2019 14:32:50 +0000 Message-Id: <20191219143447.21506-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'drivers/crypto: remove some invalid comments' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 04e0d96e4b6b519e5cdd919b3f23e2cfc3e59794 Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 30 Sep 2019 09:51:44 +0200 Subject: [PATCH] drivers/crypto: remove some invalid comments [ upstream commit 310d2ea6328c6146ccca6eac42426e060a99fedc ] A comment valid in AESNI PMD was copied and pasted in other code Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver") Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors") Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-off-by: Thierry Herbelot Acked-by: Akhil Goyal --- drivers/crypto/armv8/rte_armv8_pmd.c | 1 - drivers/crypto/mrvl/rte_mrvl_pmd.c | 1 - drivers/crypto/openssl/rte_openssl_pmd.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c index 97719f278e..d757ebfe70 100644 --- a/drivers/crypto/armv8/rte_armv8_pmd.c +++ b/drivers/crypto/armv8/rte_armv8_pmd.c @@ -803,7 +803,6 @@ cryptodev_armv8_crypto_create(const char *name, RTE_CRYPTODEV_FF_CPU_NEON | RTE_CRYPTODEV_FF_CPU_ARM_CE; - /* Set vector instructions mode supported */ internals = dev->data->dev_private; internals->max_nb_qpairs = init_params->max_nb_queue_pairs; diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c b/drivers/crypto/mrvl/rte_mrvl_pmd.c index 31f3fe581e..95276a9467 100644 --- a/drivers/crypto/mrvl/rte_mrvl_pmd.c +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c @@ -743,7 +743,6 @@ cryptodev_mrvl_crypto_create(const char *name, RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | RTE_CRYPTODEV_FF_HW_ACCELERATED; - /* Set vector instructions mode supported */ internals = dev->data->dev_private; internals->max_nb_qpairs = init_params->max_nb_queue_pairs; diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 06e1a6defc..7b18bd42e7 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -1690,7 +1690,6 @@ cryptodev_openssl_create(const char *name, RTE_CRYPTODEV_FF_CPU_AESNI | RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; - /* Set vector instructions mode supported */ internals = dev->data->dev_private; internals->max_nb_qpairs = init_params->max_nb_queue_pairs; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:27.235344013 +0000 +++ 0023-drivers-crypto-remove-some-invalid-comments.patch 2019-12-19 14:32:25.573287276 +0000 @@ -1,28 +1,29 @@ -From 310d2ea6328c6146ccca6eac42426e060a99fedc Mon Sep 17 00:00:00 2001 +From 04e0d96e4b6b519e5cdd919b3f23e2cfc3e59794 Mon Sep 17 00:00:00 2001 From: Thierry Herbelot Date: Mon, 30 Sep 2019 09:51:44 +0200 Subject: [PATCH] drivers/crypto: remove some invalid comments +[ upstream commit 310d2ea6328c6146ccca6eac42426e060a99fedc ] + A comment valid in AESNI PMD was copied and pasted in other code Fixes: 8a61c83af2fa ("crypto/mrvl: add mrvl crypto driver") Fixes: 169ca3db550c ("crypto/armv8: add PMD optimized for ARMv8 processors") Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") -Cc: stable@dpdk.org Signed-off-by: Thierry Herbelot Acked-by: Akhil Goyal --- drivers/crypto/armv8/rte_armv8_pmd.c | 1 - - drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 - + drivers/crypto/mrvl/rte_mrvl_pmd.c | 1 - drivers/crypto/openssl/rte_openssl_pmd.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c -index 0d4649adcd..711701a974 100644 +index 97719f278e..d757ebfe70 100644 --- a/drivers/crypto/armv8/rte_armv8_pmd.c +++ b/drivers/crypto/armv8/rte_armv8_pmd.c -@@ -777,7 +777,6 @@ cryptodev_armv8_crypto_create(const char *name, +@@ -803,7 +803,6 @@ cryptodev_armv8_crypto_create(const char *name, RTE_CRYPTODEV_FF_CPU_NEON | RTE_CRYPTODEV_FF_CPU_ARM_CE; @@ -30,25 +31,25 @@ internals = dev->data->dev_private; internals->max_nb_qpairs = init_params->max_nb_queue_pairs; -diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c -index ef2e5ed00d..0aafcc1503 100644 ---- a/drivers/crypto/mvsam/rte_mrvl_pmd.c -+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c -@@ -821,7 +821,6 @@ cryptodev_mrvl_crypto_create(const char *name, - RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT | - RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT; +diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c b/drivers/crypto/mrvl/rte_mrvl_pmd.c +index 31f3fe581e..95276a9467 100644 +--- a/drivers/crypto/mrvl/rte_mrvl_pmd.c ++++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c +@@ -743,7 +743,6 @@ cryptodev_mrvl_crypto_create(const char *name, + RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | + RTE_CRYPTODEV_FF_HW_ACCELERATED; - /* Set vector instructions mode supported */ internals = dev->data->dev_private; - internals->max_nb_qpairs = init_params->common.max_nb_queue_pairs; + internals->max_nb_qpairs = init_params->max_nb_queue_pairs; diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c -index 2f55528407..b05f6adb92 100644 +index 06e1a6defc..7b18bd42e7 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c -@@ -2127,7 +2127,6 @@ cryptodev_openssl_create(const char *name, - RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP | - RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT; +@@ -1690,7 +1690,6 @@ cryptodev_openssl_create(const char *name, + RTE_CRYPTODEV_FF_CPU_AESNI | + RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER; - /* Set vector instructions mode supported */ internals = dev->data->dev_private;