From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7550A04F3 for ; Thu, 19 Dec 2019 15:36:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD9701BE8E; Thu, 19 Dec 2019 15:36:02 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 3E6E61BF74 for ; Thu, 19 Dec 2019 15:36:01 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id c14so6203036wrn.7 for ; Thu, 19 Dec 2019 06:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2+jiWYw3gEO56OmPVMQbzVND0pe0AE3bVgLFBjU7ZkI=; b=mMrdkTlZmjvzdF5cWorhpqslhC6f9yAcOB9cQXq1HTxz2LluomWJvuR9HX8g+xwkjL W8/K0/KOpg/ANEwIrC3dQKYPrAB0qjV2MXZ7HT+o0QIWGBuPtfA8dby7eVkINa38d3VL CSkh8YYseFvelLIUcQnAL1oXSKyYqUq19dlVFarU+qxLt0mrvWKByekZGcwktU4wbP4a rNfof8Wyv3XB/weOqfZ4twPWJZdyfgas8gf4hkPLfvFmOV0Inr7GOxlMPGQN2BWQCImW ZaFwpA6ejLLPSlqwbXss6O7AdRlwTOx1xsNbCNfIvwMm6nvvdSarp1xdYJq/bo/k/AmX jg6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2+jiWYw3gEO56OmPVMQbzVND0pe0AE3bVgLFBjU7ZkI=; b=AAVMcdwjWofAxBnQpgteykm/vJxDecYqQqSv/TZbT9UrXiM83mZxSsWWJd0fxG0EVB yGl2ldQdbHosm47QWpz3MBa1R+fGdzFBSW81WpD1pe1vRjpOhDoRxnhAoFw+yKQHLjEg GwDGyqEo+AdzDq/fFcEreMTtK1zP+g4xkhbi6Lqk10mQzZUzw2rqTC3QINU70v1mL5t5 s51tFl9hT0VsCMH96bBcE3oQKLmtmZXznUf+zhhRXxOMioEHnCyiJGIKfbdUtlm846B1 MBuR6b/F06Z0LnlxnG7fpOTEhhSnNyvPnig5orZ3GhBPjKHwWGL+TVQjcFd4CBITvGFU ToPg== X-Gm-Message-State: APjAAAVMGau5eO8GdI3wNJIQgekGnUelSdUE/zU/XTLo09sY2Vgio0hy en00gK031XnYk81wyQRFLu4= X-Google-Smtp-Source: APXvYqwRbi4zKqA4ZQz3PiXNK83omdhWiHBPU9dyPhhKCkDMLG9mh9Q6RnxGWJahKghJ+TIYvhYRaQ== X-Received: by 2002:adf:fe12:: with SMTP id n18mr9500587wrr.158.1576766160995; Thu, 19 Dec 2019 06:36:00 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s10sm6497060wrw.12.2019.12.19.06.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:36:00 -0800 (PST) From: luca.boccassi@gmail.com To: Phil Yang Cc: Gavin Hu , Matan Azrad , dpdk stable Date: Thu, 19 Dec 2019 14:32:52 +0000 Message-Id: <20191219143447.21506-25-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix Rx CQ doorbell synchronization on aarch64' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 4cd784b02d29f706ff2297b6f65eeb680c0af9ff Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Thu, 5 Sep 2019 18:55:07 +0800 Subject: [PATCH] net/mlx5: fix Rx CQ doorbell synchronization on aarch64 [ upstream commit 94a24aaf6c5bd0a03c2828e7411d30a4fc0ac075 ] The Rx completion queue doorbell field needs to be updated after the last CQE decompressed. For the weaker memory model processors, the compiler barrier is not sufficient to guarantee the order of these operations, so use the coherent I/O memory barrier to make sure these fields are updated in order. Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") Suggested-by: Gavin Hu Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h index ae37c2bd10..950d27d303 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h @@ -1032,7 +1032,7 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, uint16_t pkts_n, rcvd_pkt += n; } } - rte_compiler_barrier(); + rte_cio_wmb(); *rxq->cq_db = rte_cpu_to_be_32(rxq->cq_ci); return rcvd_pkt; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:27.313272923 +0000 +++ 0025-net-mlx5-fix-Rx-CQ-doorbell-synchronization-on-aarch.patch 2019-12-19 14:32:25.605287911 +0000 @@ -1,8 +1,10 @@ -From 94a24aaf6c5bd0a03c2828e7411d30a4fc0ac075 Mon Sep 17 00:00:00 2001 +From 4cd784b02d29f706ff2297b6f65eeb680c0af9ff Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Thu, 5 Sep 2019 18:55:07 +0800 Subject: [PATCH] net/mlx5: fix Rx CQ doorbell synchronization on aarch64 +[ upstream commit 94a24aaf6c5bd0a03c2828e7411d30a4fc0ac075 ] + The Rx completion queue doorbell field needs to be updated after the last CQE decompressed. For the weaker memory model processors, the compiler barrier is not sufficient to guarantee the order of @@ -10,7 +12,6 @@ sure these fields are updated in order. Fixes: 570acdb1da8a ("net/mlx5: add vectorized Rx/Tx burst for ARM") -Cc: stable@dpdk.org Suggested-by: Gavin Hu Signed-off-by: Phil Yang @@ -21,11 +22,11 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h -index 99302869a7..e914d017d6 100644 +index ae37c2bd10..950d27d303 100644 --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h -@@ -727,7 +727,7 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, uint16_t pkts_n, - rxq->decompressed -= n; +@@ -1032,7 +1032,7 @@ rxq_burst_v(struct mlx5_rxq_data *rxq, struct rte_mbuf **pkts, uint16_t pkts_n, + rcvd_pkt += n; } } - rte_compiler_barrier();