patches for DPDK stable branches
 help / color / mirror / Atom feed
From: luca.boccassi@gmail.com
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'vhost: fix slave request fd leak' has been queued to LTS release 17.11.10
Date: Thu, 19 Dec 2019 14:32:54 +0000	[thread overview]
Message-ID: <20191219143447.21506-27-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/21/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
From 72baa70cdbf5b75dc14548f02923e23eb84bca71 Mon Sep 17 00:00:00 2001
From: Tiwei Bie <tiwei.bie@intel.com>
Date: Thu, 5 Sep 2019 19:01:25 +0800
Subject: [PATCH] vhost: fix slave request fd leak

[ upstream commit 761d57651c51365354cefb624883fccf62aee67d ]

We need to close the old slave request fd if any first
before taking the new one.

Fixes: 275c3f944730 ("vhost: support slave requests channel")

Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/librte_vhost/vhost_user.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 155394a6d9..221217c3f4 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1177,6 +1177,9 @@ vhost_user_set_req_fd(struct virtio_net *dev, struct VhostUserMsg *msg)
 		return -1;
 	}
 
+	if (dev->slave_req_fd >= 0)
+		close(dev->slave_req_fd);
+
 	dev->slave_req_fd = fd;
 
 	return 0;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-12-19 14:32:27.408464899 +0000
+++ 0027-vhost-fix-slave-request-fd-leak.patch	2019-12-19 14:32:25.673289259 +0000
@@ -1,13 +1,14 @@
-From 761d57651c51365354cefb624883fccf62aee67d Mon Sep 17 00:00:00 2001
+From 72baa70cdbf5b75dc14548f02923e23eb84bca71 Mon Sep 17 00:00:00 2001
 From: Tiwei Bie <tiwei.bie@intel.com>
 Date: Thu, 5 Sep 2019 19:01:25 +0800
 Subject: [PATCH] vhost: fix slave request fd leak
 
+[ upstream commit 761d57651c51365354cefb624883fccf62aee67d ]
+
 We need to close the old slave request fd if any first
 before taking the new one.
 
 Fixes: 275c3f944730 ("vhost: support slave requests channel")
-Cc: stable@dpdk.org
 
 Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
 Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
@@ -16,11 +17,11 @@
  1 file changed, 3 insertions(+)
 
 diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
-index 0b72648a5a..f468436103 100644
+index 155394a6d9..221217c3f4 100644
 --- a/lib/librte_vhost/vhost_user.c
 +++ b/lib/librte_vhost/vhost_user.c
-@@ -1564,6 +1564,9 @@ vhost_user_set_req_fd(struct virtio_net **pdev, struct VhostUserMsg *msg,
- 		return RTE_VHOST_MSG_RESULT_ERR;
+@@ -1177,6 +1177,9 @@ vhost_user_set_req_fd(struct virtio_net *dev, struct VhostUserMsg *msg)
+ 		return -1;
  	}
  
 +	if (dev->slave_req_fd >= 0)
@@ -28,7 +29,7 @@
 +
  	dev->slave_req_fd = fd;
  
- 	return RTE_VHOST_MSG_RESULT_OK;
+ 	return 0;
 -- 
 2.20.1
 

  parent reply	other threads:[~2019-12-19 14:36 UTC|newest]

Thread overview: 145+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 14:32 [dpdk-stable] patch 'net/bonding: fix LACP fast queue Rx handler' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/bonding: fix unicast packets filtering' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/fm10k: fix stats crash in multi-process' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'ethdev: fix endian annotation for SPI item' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/af_packet: fix stale sockets' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/mlx4: fix build on ppc64' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/i40e: remove memory barrier from NEON Rx' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/i40e: remove compiler " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/ixgbe: remove memory " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/ixgbe: remove redundant assignment' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'ethdev: fix typos for ENOTSUP' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/ixgbe: fix queue interrupt for X552/557' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/ixgbe: enable new PF host mbox version' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/ixgbe: fix VF RSS offloads configuration' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'doc: fix format in virtio guide' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/mlx: fix build with make and recent gcc' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'test/interrupt: account for race with callback' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'bus/pci: fix Intel IOMMU sysfs access check' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'security: fix doxygen fields' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'crypto/qat: fix digest length in XCBC capability' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'doc: fix AESNI-GCM limitations in crypto guide' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'cryptodev: fix initialization on multi-process' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'drivers/crypto: remove some invalid comments' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/i40e: downgrade error log' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'net/mlx5: fix Rx CQ doorbell synchronization on aarch64' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'ethdev: remove redundant device info cleanup before get' " luca.boccassi
2019-12-19 14:32 ` luca.boccassi [this message]
2019-12-19 14:32 ` [dpdk-stable] patch 'net/bonding: fix link speed update in broadcast mode' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'app/testpmd: fix crash on port reset' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'vhost: forbid reallocation when running' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'vhost: fix vring address handling during live migration' " luca.boccassi
2019-12-19 14:32 ` [dpdk-stable] patch 'vhost: protect vring access done by application' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/vhost: fix redundant queue state event' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: get all pending Rx packets in vectorized paths' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: fix mbuf data and packet length mismatch' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/cxgbe: fix prefetch for non-coalesced Tx packets' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/ixgbe: fix X553 speed capability' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bonding: fix slave id types' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bonding: fix OOB access in other aggregator modes' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: remove duplicate barrier' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: enforce IO barrier for doorbell command' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix async link handling and update' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix Rx queue count' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix crash in secondary process' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix setting default MAC address' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix multicast filter programming' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/qede: limit Rx ring index read for debug' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'event/sw: fix xstats reset value' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'event/dpaa2: fix default queue configuration' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'service: use log for error messages' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'test/mbuf: fix forged mbuf in clone test' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'test/lpm: fix measured cycles for delete' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'cryptodev: fix checks related to device id' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'doc: fix typo in l2fwd-crypto guide' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'lib/distributor: fix deadlock on aarch64' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'bus/pci: remove useless link dependency on ethdev' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'test/bonding: fix LSC related cases' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/tap: fix blocked Rx packets' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix stats errors handling' " luca.boccassi
2019-12-19 14:56   ` Kalesh Anakkur Purayil
2019-12-24 11:16     ` Luca Boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: return error if setting link up fails' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: remove redundant header file inclusion' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: get default HWRM command timeout from FW' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix coding style' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: remove unnecessary variable assignment' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/dpaa2: set port in mbuf' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix dereference before null check' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: cleanup comments' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: move macro definitions to header file' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix error handling in xstats' " luca.boccassi
2019-12-19 14:57   ` Kalesh Anakkur Purayil
2019-12-24 11:16     ` Luca Boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'vhost: translate incoming log address to GPA' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'vhost: prevent zero copy mode if IOMMU is on' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: fix descriptor addressed in Tx' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/i40e: fix address of first segment' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/ixgbe: " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'doc: fix a common typo in NIC guides' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'app/testpmd: fix help for loop topology option' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/af_packet: improve Tx statistics accuracy' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/igb: fix global variable multiple definitions' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'test: " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'vfio: fix truncated BAR offset for 32-bit' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'ethdev: fix include of ethernet header file' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix mbuf free when clearing Tx queue' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/i40e: fix exception with multi-driver' " luca.boccassi
2019-12-20  1:45   ` Zhang, AlvinX
2019-12-24 11:16     ` Luca Boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: reject deferred Rx start' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: reject deferred Tx " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'vhost: fix IPv4 checksum' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/mlx: fix debug build with icc' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'app/testpmd: fix Tx checksum when TSO enabled' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: expose some missing counters in port stats' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bnxt: fix memory leak' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/virtio: fix Tx checksum offloads' " luca.boccassi
2019-12-19 14:33 ` [dpdk-stable] patch 'net/bonding: use non deprecated PCI API' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/vm_power: fix type of cmdline token in cli' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/l3fwd-power: fix Rx interrupt disabling' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'power: fix socket indicator value' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/vm_power: fix build without i40e' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'usertools: fix pmdinfo with python 3 and pyelftools>=0.24' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/dpaa2: add retry and timeout in packet enqueue API' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'mempool/dpaa2: report error on endless loop in mbuf release' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'doc: fix description of versioning macros' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/dpaa2: fix possible use of uninitialized vars' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/bnxt: remove commented out code' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'crypto/dpaa2_sec: fix length retrieved from hardware' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix GCM IV length' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix SHA256-HMAC digest " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'crypto/openssl: use local copy for session contexts' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/fm10k: fix mbuf free in vector Rx' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/igb: fix PHY status if PHY reset is not blocked' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/bonding: fix port ID check' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/qede: fix setting MTU' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/qede: fix setting VLAN strip mode' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/ixgbe: support packet type with NEON' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/ixgbe: fix link status' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'vhost: fix virtqueue not accessible' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/virtio-user: fix setting filters' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/sfc: fix adapter lock usage on rule creation' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'app/testpmd: block xstats for hidden ports' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'bus/pci: align next mapping address on page boundary' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'test: optimise fd closing in forks' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'doc/guides: clean repeated words' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'lib: fix log typos' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'lib: fix doxygen " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'malloc: fix realloc copy size' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'malloc: fix realloc padded element " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix default configuration' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/bnxt: fix crash in xstats get' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/bnxt: fix log message level' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/bonding: fix selection logic' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'power: handle frequency increase with turbo disabled' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'mk: remove library search path from binary' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'examples/multi_process: fix client crash with sparse ports' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'app/crypto-perf: fix input of AEAD decrypt' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'doc: fix tap guide' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'app/testpmd: use better randomness for Tx split' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/ixgbe: fix link status' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'net/e1000: " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'ethdev: limit maximum number of queues' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'event/octeontx: fix partial Rx packet handling' " luca.boccassi
2019-12-19 14:34 ` [dpdk-stable] patch 'test/service: fix wait for service core' " luca.boccassi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191219143447.21506-27-luca.boccassi@gmail.com \
    --to=luca.boccassi@gmail.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).