From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C1EA04F3 for ; Thu, 19 Dec 2019 15:36:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2ED4D1BF72; Thu, 19 Dec 2019 15:36:07 +0100 (CET) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by dpdk.org (Postfix) with ESMTP id 285F11BF72 for ; Thu, 19 Dec 2019 15:36:06 +0100 (CET) Received: by mail-wr1-f52.google.com with SMTP id w15so6230665wru.4 for ; Thu, 19 Dec 2019 06:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mnEDqI2tzcbUHM32Dk27I2Cs1J32naJAiaDLwNMbKdU=; b=ILv7ZYlg+qH4adZBpbGowR2pE+DZqR6jMmZNb1MgYedAfW7TpQwfvZU/Jz9ge5mlMH 3Lj2hl+q1095zLt4oqa6ajFitDIiyNaTruL+kcRf51aK8/ONJLsPtDEA5uU//SJfFJ13 hgoIz9UhAHXXJKi3qC9KIS3sE/dP4MHRgD7qnIcGJWQaOxVph6QGj7QMLjFPsuaSkgvI FbDSETGuTUzszC55nZ/LqQsnCCUTNz4l8LowfoWSMi9OwWo2/mNDEoD6+AyDjHWJhxq8 gGjtvN6g6xJtz+Q98IiXRudzwpwegzzwWE89gV819N3n9pRmsOvwSyDr3tHzXDU8ZYRf PHeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mnEDqI2tzcbUHM32Dk27I2Cs1J32naJAiaDLwNMbKdU=; b=KZqVjBtY4g6rhNFDxJcQ0vCQMKs9e1JbV21ii/BTNjUXI4770ubBX3IkQvn91NuCML GYXvZltf+zZRS9TI0+a/OhQmfN+CCg0/5xRrqV9vgFcyDvjBPgbASDgFiK+a+HbmAiqF mcOwc0uys5HSDlddlIyULmWnpzTh6HCYHO+PdDBOcjHcJVJsBdcJjs6dkneTVd/1pFKN v/ax5kV/ZSxu/zATXfr51VcXJ6CX5xiBde1Kmjx9pS5/+nOyfYGdtaNuR2v4sKjbKk+K DEAyzj/3T89cQb5EZOhdA+NRjpa+f9fntnb7Fj4BerGGNmWXS3QxRQPhNs8KBrlXg6xI RLLg== X-Gm-Message-State: APjAAAV2nWqWc5Hk+CcHsgu22wnk+dAFgmRf7BY+JkOmSytFufhbOoOS WLGujq3HccQ+CuwBGgQPnhMReohj7EM= X-Google-Smtp-Source: APXvYqwvyjfh4SrX27sDHxBT1ZVmtiQSEe1HKVbu8ZeaQIzMHx6ESVSskzwHzg0toOi3zm/f137o1A== X-Received: by 2002:adf:f311:: with SMTP id i17mr9725563wro.81.1576766165779; Thu, 19 Dec 2019 06:36:05 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id i16sm6553233wmb.36.2019.12.19.06.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:36:05 -0800 (PST) From: luca.boccassi@gmail.com To: Igor Romanov Cc: Andrew Rybchenko , Chas Williams , dpdk stable Date: Thu, 19 Dec 2019 14:32:55 +0000 Message-Id: <20191219143447.21506-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bonding: fix link speed update in broadcast mode' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 013aaa6d373bf4cf91d554357f8e93eeb42af117 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Tue, 10 Sep 2019 09:25:41 +0100 Subject: [PATCH] net/bonding: fix link speed update in broadcast mode [ upstream commit db3216e76609647ce8dc256d478c8cc7095a23d4 ] Fix the issue that the link speed of the bond device was set to the link speed of the first active slave in broadcast mode. Set the link speed of the bond device to the minimum value across all of the slaves in that case. Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index e2487e5f71..b58873a2c2 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2326,8 +2326,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete) * packet loss will occur on this slave if transmission at rates * greater than this are attempted */ - for (idx = 1; idx < bond_ctx->active_slave_count; idx++) { - link_update(bond_ctx->active_slaves[0], &slave_link); + for (idx = 0; idx < bond_ctx->active_slave_count; idx++) { + link_update(bond_ctx->active_slaves[idx], &slave_link); if (slave_link.link_speed < ethdev->data->dev_link.link_speed) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:27.450275585 +0000 +++ 0028-net-bonding-fix-link-speed-update-in-broadcast-mode.patch 2019-12-19 14:32:25.689289576 +0000 @@ -1,8 +1,10 @@ -From db3216e76609647ce8dc256d478c8cc7095a23d4 Mon Sep 17 00:00:00 2001 +From 013aaa6d373bf4cf91d554357f8e93eeb42af117 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Tue, 10 Sep 2019 09:25:41 +0100 Subject: [PATCH] net/bonding: fix link speed update in broadcast mode +[ upstream commit db3216e76609647ce8dc256d478c8cc7095a23d4 ] + Fix the issue that the link speed of the bond device was set to the link speed of the first active slave in broadcast mode. @@ -10,7 +12,6 @@ all of the slaves in that case. Fixes: deba8a2f8b0b ("net/bonding: fix link properties management") -Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko @@ -20,10 +21,10 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c -index 5ff9fcbaf7..4c517e676d 100644 +index e2487e5f71..b58873a2c2 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c -@@ -2395,8 +2395,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete) +@@ -2326,8 +2326,8 @@ bond_ethdev_link_update(struct rte_eth_dev *ethdev, int wait_to_complete) * packet loss will occur on this slave if transmission at rates * greater than this are attempted */