From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C41AA04F3 for ; Thu, 19 Dec 2019 15:37:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C2311BF76; Thu, 19 Dec 2019 15:37:19 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id D5A591BF78 for ; Thu, 19 Dec 2019 15:37:16 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id j42so6180198wrj.12 for ; Thu, 19 Dec 2019 06:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F3zsLBzsZ7knMOuXHzJhX8D3bvQQmkLrSTpMtbytRaA=; b=u5I3/9DrmTyu5C3BoW6xsjMZSzVG581BIn6gJKCoLRqOWONDLqE976dK6ipw2wDobI k272eEm+NeQ9iir9BDdhXtxjepa/9t8m3b2M3EncpG62xMepBKGT8eEpyMI9U6N85uoH RJJtFDURBMAri/aObuXIH7ODA4bvEknMux3JdkpQvqUuIVPeKJV+FHBTqENXgwQSRzb6 Rod1G+BwcJuJTzM6XisXeJLafVvmJvZB7QwiKZw5XnsMExnZQRJAvo+XjqYDv+rSATph DEzEoK//umfjn8qeBG5H+/sJxioGjXafjIk3vmXDMwGS6ZlH81ap1f21GKojlsOf1T1m mMlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F3zsLBzsZ7knMOuXHzJhX8D3bvQQmkLrSTpMtbytRaA=; b=SLhsQxrQixKiKGkX0oM4CpFDMq9ERuAe0jtWwr+t8PnrXvXqIJLxFOg/62cWTCY0BI uWMo+AR4Gno0xuxbM8ZgIJdZACL86X3amaRKLNLkiBetqm1DsJ+npYZ+iNcADtDQdNPY IDmwvNiLG3nmaTYjEgbPkwGKLSCnEnqVTNimowM/GSStgihw6P5zedE0HyubS6nKM7pM PxQ36Gc7SEAHdw7vfpMSJXm/3FxD0tY6RJoIgLZiRotRVypQdt39E5oQC0I5FwoLQ7MX eRcc8rFgp/yXBZiag2gr5fZsUAolVG17jxAQsVz1EHdEdBqR3gBIWVdg0MCi1A49pPt2 hgxw== X-Gm-Message-State: APjAAAWz5mkvgix3jqMRDzjENEEi25gY5jzD653Ka9m+jznEVwVIp5CB QwKISDsCFR3qPuTumO9Qe9qvTQphX5U= X-Google-Smtp-Source: APXvYqyl3DkbOvUVi944mK859L/Hi/XXnsqiLAOiIMuCOpkqIS0WMRF8rRd+m19p9uQEm0GN6IguIw== X-Received: by 2002:adf:fbc9:: with SMTP id d9mr10180359wrs.20.1576766236420; Thu, 19 Dec 2019 06:37:16 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g17sm6171833wmc.37.2019.12.19.06.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:37:15 -0800 (PST) From: luca.boccassi@gmail.com To: Seth Howell Cc: Gaetan Rivet , dpdk stable Date: Thu, 19 Dec 2019 14:33:23 +0000 Message-Id: <20191219143447.21506-56-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'bus/pci: remove useless link dependency on ethdev' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 8a9c8c090d5c96245e9bd1e38ef20fae8faa0c01 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Fri, 11 Oct 2019 13:56:07 -0700 Subject: [PATCH] bus/pci: remove useless link dependency on ethdev [ upstream commit c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa ] The makefile in drivers/bus/pci specified rte_ethdev as a dependency for the library. However there are no actual symbols from librte_ethdev used in librte_bus_pci. Including librte_ethdev as a dependency only becomes a problem in some niche cases like when attempting to build the rte_bus_pci library as a shared object without building the rte_ethdev library. I specifically ran into this when trying to build the DPDK included as an SPDK submodule on a FreeBSD machine. I figure that since there are no real dependencies between the two, we should enable building librte_bus_pci without librte_ethdev. Fixes: c752998b5e2e ("pci: introduce library and driver") Signed-off-by: Seth Howell Acked-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile index f3df1c4ce4..37663deb08 100644 --- a/drivers/bus/pci/Makefile +++ b/drivers/bus/pci/Makefile @@ -50,7 +50,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_pci +LDLIBS += -lrte_pci include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) := $(addprefix $(SYSTEM)/,$(SRCS)) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:28.548292637 +0000 +++ 0056-bus-pci-remove-useless-link-dependency-on-ethdev.patch 2019-12-19 14:32:26.089297508 +0000 @@ -1,8 +1,10 @@ -From c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa Mon Sep 17 00:00:00 2001 +From 8a9c8c090d5c96245e9bd1e38ef20fae8faa0c01 Mon Sep 17 00:00:00 2001 From: Seth Howell Date: Fri, 11 Oct 2019 13:56:07 -0700 Subject: [PATCH] bus/pci: remove useless link dependency on ethdev +[ upstream commit c345c7d1acf43b4d30e1ecdd5a8cd3402234a6aa ] + The makefile in drivers/bus/pci specified rte_ethdev as a dependency for the library. However there are no actual symbols from librte_ethdev used in librte_bus_pci. @@ -17,7 +19,6 @@ librte_bus_pci without librte_ethdev. Fixes: c752998b5e2e ("pci: introduce library and driver") -Cc: stable@dpdk.org Signed-off-by: Seth Howell Acked-by: Gaetan Rivet @@ -26,15 +27,15 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile -index 68c1f3fde4..45d12427a1 100644 +index f3df1c4ce4..37663deb08 100644 --- a/drivers/bus/pci/Makefile +++ b/drivers/bus/pci/Makefile -@@ -25,7 +25,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common - CFLAGS += -DALLOW_EXPERIMENTAL_API +@@ -50,7 +50,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common + CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring --LDLIBS += -lrte_ethdev -lrte_pci -lrte_kvargs -+LDLIBS += -lrte_pci -lrte_kvargs +-LDLIBS += -lrte_ethdev -lrte_pci ++LDLIBS += -lrte_pci include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) := $(addprefix $(SYSTEM)/,$(SRCS))