From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0001A04F3 for ; Thu, 19 Dec 2019 15:37:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B295D1BF7C; Thu, 19 Dec 2019 15:37:24 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 0C4261BF7C for ; Thu, 19 Dec 2019 15:37:23 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id t14so5839621wmi.5 for ; Thu, 19 Dec 2019 06:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AFjI7y/CHnMaeRxo61arE0u5LktGJr1uIDz4LR8I25Y=; b=as8bRx0Xbxk8sT0nTThuNYKdi0SgG9juxC13aDTuMtLe78t1eDsKrnFkCh1erq+1Kp AXt+jrnSgreFqb6jfdKtqV0tL1tpGYV3ava0hyzO5cdJEnR8tgOABuQZ96uhksZm13zz sN4zsPM2iU2SZM6m5xk4aexZN3x/bYzQcNWweuF8EC2WHUOhHP/bcGcuhZogppA7DOQs 1YHJ4tPipDp4yNSDK/Lt4/f1eAXwEfeEDlVL9tV6X4WV/m9JiKti4gkzrYpy89vcOTvD J3JxZcP35FwubP64dElDGT7psbGr/jNfX+qH8W/dfP4bKNTs0pp+e5i3roMB5V9AEDC9 fZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AFjI7y/CHnMaeRxo61arE0u5LktGJr1uIDz4LR8I25Y=; b=qDYNRFw2wN/9cMnGmlR0E8apaeDb9BsnvuGqzdHJyRhJl5dRpUIXilanOTyhzUAPvj KFyI5TW8EdHpQeAifrTEzKCCKmURyVMCUJEnpx+rMqlRPqOshtdJjDhwSe4p+fAj9grK lVa1fGFs7jwRNxu9OXESM++PuVqCF2CsXlafiuLSEQLT8bDB3DE0WP8Czur2YhEzIsoq 8YiFTPYCDhKhkMcWS5dLDNLhZfzmWeD33jXN2hR1OpzZ6mmCF5+fO/PAX/x/V7dTXmwZ +965jUDaTgqs3BaFSOvFl4uCeEVbVYN9ClIu2+tknveVD8Oouo3sVl0NlWngh1ULph01 e8aA== X-Gm-Message-State: APjAAAVsbbLz+XcJyN/IjfqA3dv5Upz7LCCXuSvewXfFH6DoswEdUs4D YCQv28hV2lrihUN/WRFRzEY= X-Google-Smtp-Source: APXvYqw/oElBdvKLcVomvpdYiyu6K6QMfI1oKYP3mpPtVx4hj9HLHythjJq9cKhp1Z7niPusM5vT/Q== X-Received: by 2002:a1c:9d52:: with SMTP id g79mr10546267wme.148.1576766242802; Thu, 19 Dec 2019 06:37:22 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id j2sm6440990wmk.23.2019.12.19.06.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:37:22 -0800 (PST) From: luca.boccassi@gmail.com To: Kalesh AP Cc: Somnath Kotur , dpdk stable Date: Thu, 19 Dec 2019 14:33:27 +0000 Message-Id: <20191219143447.21506-60-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: return error if setting link up fails' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 5740d27982bc7527c00b25d34c5674e6ca078547 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Wed, 9 Oct 2019 18:41:44 -0700 Subject: [PATCH] net/bnxt: return error if setting link up fails [ upstream commit acf2f2a451c0328e175f8d53ad19f3c160773697 ] Currently bnxt driver does not return error in case setting link up fails. Fixes: 5c206086feaa ("net/bnxt: add link state operations") Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index cbeb97b88e..3b74ea4a0d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -629,7 +629,7 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) eth_dev->data->dev_link.link_status = 1; bnxt_print_link_info(eth_dev); - return 0; + return rc; } static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:28.699280279 +0000 +++ 0060-net-bnxt-return-error-if-setting-link-up-fails.patch 2019-12-19 14:32:26.113297984 +0000 @@ -1,12 +1,13 @@ -From acf2f2a451c0328e175f8d53ad19f3c160773697 Mon Sep 17 00:00:00 2001 +From 5740d27982bc7527c00b25d34c5674e6ca078547 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Wed, 9 Oct 2019 18:41:44 -0700 Subject: [PATCH] net/bnxt: return error if setting link up fails +[ upstream commit acf2f2a451c0328e175f8d53ad19f3c160773697 ] + Currently bnxt driver does not return error in case setting link up fails. Fixes: 5c206086feaa ("net/bnxt: add link state operations") -Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur @@ -15,10 +16,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c -index 294a9505f9..4b39586479 100644 +index cbeb97b88e..3b74ea4a0d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c -@@ -930,7 +930,7 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) +@@ -629,7 +629,7 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) eth_dev->data->dev_link.link_status = 1; bnxt_print_link_info(eth_dev);