From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DB41A04F3 for ; Thu, 19 Dec 2019 15:37:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 136C01BF92; Thu, 19 Dec 2019 15:37:45 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 1DF641BF92 for ; Thu, 19 Dec 2019 15:37:44 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id g17so6229143wro.2 for ; Thu, 19 Dec 2019 06:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vRW0q/5orGgUJiNe4HVks65NFxfztFjz7rFdETw/NTs=; b=k1Y0lrosQrFeL8rbHneYYp77DSmAvcfZU298Ll9wui6CfCol7BPJuBtQG0fKI6e9Ly rf+aq7UqVaHY0O6+v8e0+okajQSFCTE5IvDovlG6HEOtkDLUDmpR65dpS0qdWQAWy4FU bQ/c3Wh/3o1QGb2oYbSmg3TElmS+ZR+OJJrDUBm1p5twLZed/a+zK75OEFgrgqIPk3wb G3KUfJCaTDLMULATaiT8RJc/IftJHNSphvwVKeQpB9Yca2FWoTCJ480AWw0cKKLen31H oqRk/rT0NYMuJBigVUiY4LCieE1Gk0Ebk4W4KLK2OPn98zC2vOKeNL1LMy4k1QYs4DqA rXXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vRW0q/5orGgUJiNe4HVks65NFxfztFjz7rFdETw/NTs=; b=P5QN0T+mVyIFglUM2I1Oy1xcFwUAXrbh9tLkfauqwZTWeKdKXdYr32nKO6z+pmb8JM j+GBeZASFxlFTI1ZMm8pkqQYhHihWzWvpM1FmlTJqPKZwZUsVnVwjQxIjLBCClceRqlu p0pTs4re4Ch4pyIi8+vPZB3xhCsvI3TXAt/+EB3LKFdfbLUVZS686uPBGKnIIAAgnCgL sRLB0yc76eNRkTjVoS9Y9QOhswGe8DHqk4ZRvYQSNw86rQ+/AB8Dyh3+Q9rpCvHOlN3Q 4kkrmCbgsxSedUohNYatKc66OL2U0E/KKcHeVNelYkQgOHUsXyUqisNen03AbvQoR+J/ +f1g== X-Gm-Message-State: APjAAAW/WT9jBBgzwlDhsqruhbNf38FJ2fv1xRWPOMC/9jpgoBM0OCTO 3ifm97BGFqtyOxouv+VIuog= X-Google-Smtp-Source: APXvYqxwtLsiCVBD6FgFS4xJ70crXYDxWhiDOgoKgtNR9UYgala9C58TmogD/9RW/uh4geK9PuY+Ag== X-Received: by 2002:adf:f990:: with SMTP id f16mr10011288wrr.185.1576766263764; Thu, 19 Dec 2019 06:37:43 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c15sm6548020wrt.1.2019.12.19.06.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:37:43 -0800 (PST) From: luca.boccassi@gmail.com To: Joyce Kong Cc: Xiao Zhang , Xiaolong Ye , dpdk stable Date: Thu, 19 Dec 2019 14:33:40 +0000 Message-Id: <20191219143447.21506-73-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix address of first segment' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 820e4efd2d8e76fe7cdc591171bdd4be98375b68 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Tue, 24 Sep 2019 13:48:44 +0800 Subject: [PATCH] net/i40e: fix address of first segment [ upstream commit ff4f8e24d535df81557f3dcef64d1aef8251f277 ] This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343422, 343403 Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver") Signed-off-by: Joyce Kong Reviewed-by: Xiao Zhang Reviewed-by: Xiaolong Ye --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c index c2a85fcc20..4b77e8cf4f 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -503,6 +503,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, i++; if (i == nb_bufs) return nb_bufs; + rxq->pkt_first_seg = rx_pkts[i]; } return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i, &split_flags[i]); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:29.221706237 +0000 +++ 0073-net-i40e-fix-address-of-first-segment.patch 2019-12-19 14:32:26.165299015 +0000 @@ -1,15 +1,16 @@ -From ff4f8e24d535df81557f3dcef64d1aef8251f277 Mon Sep 17 00:00:00 2001 +From 820e4efd2d8e76fe7cdc591171bdd4be98375b68 Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Tue, 24 Sep 2019 13:48:44 +0800 Subject: [PATCH] net/i40e: fix address of first segment +[ upstream commit ff4f8e24d535df81557f3dcef64d1aef8251f277 ] + This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343422, 343403 Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver") -Cc: stable@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Xiao Zhang @@ -19,10 +20,10 @@ 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c -index 864eb9a325..deb185fe2f 100644 +index c2a85fcc20..4b77e8cf4f 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c -@@ -474,6 +474,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, +@@ -503,6 +503,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, i++; if (i == nb_bufs) return nb_bufs;