From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E9FCA04F3 for ; Thu, 19 Dec 2019 15:35:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 453CF1BE8E; Thu, 19 Dec 2019 15:35:19 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 402A41BF71 for ; Thu, 19 Dec 2019 15:35:18 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id m24so5656301wmc.3 for ; Thu, 19 Dec 2019 06:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PTZV4W0naafok3L3jnEwM0MEo08yB6VuGI0ohuhLSs0=; b=Y5pwZyXnR+HBuWj5I7+n55pJFkmmmhzTU1xtX3XGwVkfr+0kYsgOKT4OuipAkSdtn5 P+FLbjc/X+mZhaapRKPBKBhiODMmi3WMA2p5FH53RRsnKKQ7t/HrV6DW7/knL80RsWUB XJDFMeeX4w/Sl7h1kLfxp/E/S6d1ytyar7H8rhi04Jtnew7yV+kkD4y5yt9cNVNx9BMN hnZBvdEUDdyOOH+PBWJs1a+E7AGtbSwd18gICPuL/4Opd9tge2vLrn1Buy4/7Pdwtin5 sNcH0U1UI83xO0kSySqjMiyWmVwvhl3h14TbgQPRcmiqf9zqLRoIsu5jZuSFi5gRLM0m xWtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PTZV4W0naafok3L3jnEwM0MEo08yB6VuGI0ohuhLSs0=; b=C5z0MM3OxwOedPtujEqCvaa+F77oA8VSZZbcawqGO3Q4l+a93RWKGalJLSn1fk462/ 46/OZwv9E8Srnw7DclryZ6OAfGtvnmu1K0Z8jfHExXAmkGKXha0ttRzCZVp9YbxXSOzz 50S56EGz5bnpnKjF0x+8ZKSjxxa/m0ekigPqumO1uoc1HXkPPM3hC6DEVKo/WEGnY+a/ P9k0QAbeTtbTJfOGQ03RUoBggUaRKmIQEcDh5H22yp1+4GnUPQB11AiSrfVbbUFsCuo/ MgFf6EvKV+eoP4CIsTzqLk8i2S5OoIzel/VTAbNJyEAVqDwmClgzfKQ77Gnv0IjHqIHv Sxqg== X-Gm-Message-State: APjAAAXiAjfPO6QuSKLxn6kiPhyLGu+w6vUmSOmeJCWHrcPgZWs6Elog WSsv1umGf5ICtng70M4kuE4= X-Google-Smtp-Source: APXvYqy3IkZ9/0aE++K1JdutbXmSiNJDdD1smSzCyXxRFZo38HfUOFi9UtD0ufOOEeOCJN+6pl407w== X-Received: by 2002:a1c:a795:: with SMTP id q143mr9971809wme.52.1576766117984; Thu, 19 Dec 2019 06:35:17 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g199sm6780726wmg.12.2019.12.19.06.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 06:35:17 -0800 (PST) From: luca.boccassi@gmail.com To: Gavin Hu Cc: Ruifeng Wang , Steve Capper , dpdk stable Date: Thu, 19 Dec 2019 14:32:35 +0000 Message-Id: <20191219143447.21506-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191219143447.21506-1-luca.boccassi@gmail.com> References: <20191219143447.21506-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: remove compiler barrier from NEON Rx' has been queued to LTS release 17.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/21/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 3cb647149999c8d2ba1e68ab64c74cfa0ef42215 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 13 Aug 2019 18:43:31 +0800 Subject: [PATCH] net/i40e: remove compiler barrier from NEON Rx [ upstream commit f1f0f39806d97a9a4d74d47ce7fb04e9b4943e08 ] As packet length extraction code was simplified,the ordering was not necessary any more.[1] 2% performance gain was measured on Marvell ThunderX2. 4.3% performance gain was measured on Ampere eMAG80 [1] http://mails.dpdk.org/archives/dev/2016-April/037529.html Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Steve Capper --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c index 3fb7de2dbc..c2a85fcc20 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -336,9 +336,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, rte_mbuf_prefetch_part2(rx_pkts[pos + 3]); } - /* avoid compiler reorder optimization */ - rte_compiler_barrier(); - /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/ uint32x4_t len3 = vshlq_u32(vreinterpretq_u32_u64(descs[3]), len_shl); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-12-19 14:32:26.651347198 +0000 +++ 0008-net-i40e-remove-compiler-barrier-from-NEON-Rx.patch 2019-12-19 14:32:25.401283865 +0000 @@ -1,8 +1,10 @@ -From f1f0f39806d97a9a4d74d47ce7fb04e9b4943e08 Mon Sep 17 00:00:00 2001 +From 3cb647149999c8d2ba1e68ab64c74cfa0ef42215 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Tue, 13 Aug 2019 18:43:31 +0800 Subject: [PATCH] net/i40e: remove compiler barrier from NEON Rx +[ upstream commit f1f0f39806d97a9a4d74d47ce7fb04e9b4943e08 ] + As packet length extraction code was simplified,the ordering was not necessary any more.[1] @@ -12,7 +14,6 @@ [1] http://mails.dpdk.org/archives/dev/2016-April/037529.html Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") -Cc: stable@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang @@ -22,10 +23,10 @@ 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c -index 5555e9b5cf..864eb9a325 100644 +index 3fb7de2dbc..c2a85fcc20 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c -@@ -307,9 +307,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, +@@ -336,9 +336,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, rte_mbuf_prefetch_part2(rx_pkts[pos + 3]); }