* [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read
@ 2019-12-31 6:53 Andy Pei
2020-01-02 0:36 ` Xu, Rosen
2020-01-03 7:43 ` Ye Xiaolong
0 siblings, 2 replies; 3+ messages in thread
From: Andy Pei @ 2019-12-31 6:53 UTC (permalink / raw)
To: dev; +Cc: andy.pei, stable, ferruh.yigit, rosen.xu, xiaolong.ye
To read line side statistics register, eth_group_sel
args in function ipn3ke_indirect_mac_read should be 0.
When eth_group_sel is 1, the nic side register is read.
Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
Cc: andy.pei@intel.com
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
Cc: ferruh.yigit@intel.com
Cc: rosen.xu@intel.com
Cc: xiaolong.ye@intel.com
drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index 8d9ebef..80122e3 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
&tmp,
IPN3KE_25G_TX_STATISTICS_STATUS,
port_id,
- 1);
+ 0);
if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
tmp = 0x00000000;
(*hw->f_mac_read)(hw,
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read
2019-12-31 6:53 [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read Andy Pei
@ 2020-01-02 0:36 ` Xu, Rosen
2020-01-03 7:43 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Xu, Rosen @ 2020-01-02 0:36 UTC (permalink / raw)
To: Pei, Andy, dev; +Cc: stable, Yigit, Ferruh, Ye, Xiaolong
Hi,
> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Tuesday, December 31, 2019 14:54
> To: dev@dpdk.org
> Cc: Pei, Andy <andy.pei@intel.com>; stable@dpdk.org; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Xu, Rosen <rosen.xu@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>
> Subject: [PATCH] net/ipn3ke: fix line side statistics register read
>
> To read line side statistics register, eth_group_sel args in function
> ipn3ke_indirect_mac_read should be 0.
> When eth_group_sel is 1, the nic side register is read.
>
> Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
> Cc: andy.pei@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
> Cc: ferruh.yigit@intel.com
> Cc: rosen.xu@intel.com
> Cc: xiaolong.ye@intel.com
>
> drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index 8d9ebef..80122e3 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
> &tmp,
> IPN3KE_25G_TX_STATISTICS_STATUS,
> port_id,
> - 1);
> + 0);
> if (tmp &
> IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
> tmp = 0x00000000;
> (*hw->f_mac_read)(hw,
> --
> 1.8.3.1
Acked-by: Rosen Xu <rosen.xu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read
2019-12-31 6:53 [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read Andy Pei
2020-01-02 0:36 ` Xu, Rosen
@ 2020-01-03 7:43 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2020-01-03 7:43 UTC (permalink / raw)
To: Andy Pei; +Cc: dev, stable, ferruh.yigit, rosen.xu
On 12/31, Andy Pei wrote:
>To read line side statistics register, eth_group_sel
>args in function ipn3ke_indirect_mac_read should be 0.
>When eth_group_sel is 1, the nic side register is read.
>
>Fixes: 5a6d883878db ("net/ipn3ke: implement statistics")
>Cc: andy.pei@intel.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Andy Pei <andy.pei@intel.com>
>---
>Cc: ferruh.yigit@intel.com
>Cc: rosen.xu@intel.com
>Cc: xiaolong.ye@intel.com
>
> drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
>index 8d9ebef..80122e3 100644
>--- a/drivers/net/ipn3ke/ipn3ke_representor.c
>+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
>@@ -701,7 +701,7 @@ struct ipn3ke_rpst_hw_port_stats *hw_stats)
> &tmp,
> IPN3KE_25G_TX_STATISTICS_STATUS,
> port_id,
>- 1);
>+ 0);
> if (tmp & IPN3KE_25G_TX_STATISTICS_STATUS_SHADOW_REQUEST_MASK) {
> tmp = 0x00000000;
> (*hw->f_mac_read)(hw,
>--
>1.8.3.1
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 7:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-31 6:53 [dpdk-stable] [PATCH] net/ipn3ke: fix line side statistics register read Andy Pei
2020-01-02 0:36 ` Xu, Rosen
2020-01-03 7:43 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).