patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: david.marchand@redhat.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] build: explicitly enable sse4 for meson builds
Date: Fri, 3 Jan 2020 13:55:21 +0000
Message-ID: <20200103135521.GA570@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191223103840.2848732-1-bruce.richardson@intel.com>

+stable

This patch is probably worthwhile taking into 19.11 and 18.11 branches to
reduce chances of failures on CI of stable trees.

On Mon, Dec 23, 2019 at 10:38:40AM +0000, Bruce Richardson wrote:
> If the compiler does not recognise the specific CPU when building with the
> default "native" machine type, sse4.2 instructions can be missing, causing
> a build error. Rather than advising the user to change the machine type,
> we can just turn on SSE4.2 directly. This can prevent issues with running
> automated tests with older compilers/distros on newer hardware.
> 
Cc: stable@dpdk.org
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> V2: insert missing quotes around "-msse4"
> ---
>  config/x86/meson.build | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/config/x86/meson.build b/config/x86/meson.build
> index 8b0fa3e6f..adc857ba2 100644
> --- a/config/x86/meson.build
> +++ b/config/x86/meson.build
> @@ -15,11 +15,9 @@ if not is_windows
>  endif
>  
>  # we require SSE4.2 for DPDK
> -sse_errormsg = '''SSE4.2 instruction set is required for DPDK.
> -Please set the machine type to "nehalem" or "corei7" or higher value'''
> -
>  if cc.get_define('__SSE4_2__', args: machine_args) == ''
> -	error(sse_errormsg)
> +	message('SSE 4.2 not enabled by default, explicitly enabling')
> +	machine_args += '-msse4'
>  endif
>  
>  base_flags = ['SSE', 'SSE2', 'SSE3','SSSE3', 'SSE4_1', 'SSE4_2']
> -- 
> 2.24.1
> 

       reply	other threads:[~2020-01-03 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191217140838.2711906-1-bruce.richardson@intel.com>
     [not found] ` <20191223103840.2848732-1-bruce.richardson@intel.com>
2020-01-03 13:55   ` Bruce Richardson [this message]
2020-01-03 14:52     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103135521.GA570@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git