From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
anatoly.burakov@intel.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] mem: fix incorrect munmap in error unwind
Date: Mon, 6 Jan 2020 12:55:53 -0800 [thread overview]
Message-ID: <20200106205553.3696-1-stephen@networkplumber.org> (raw)
The loop to unwind existing mmaps was only unmapping the
first segment.
Also, remove obvious redundant assignment.
Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Cc: anatoly.burakov@intel.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/linux/eal/eal_memory.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c
index 43e4ffc757bd..cf5b2433614b 100644
--- a/lib/librte_eal/linux/eal/eal_memory.c
+++ b/lib/librte_eal/linux/eal/eal_memory.c
@@ -1967,9 +1967,8 @@ eal_legacy_hugepage_attach(void)
close(fd);
error:
/* map all segments into memory to make sure we get the addrs */
- cur_seg = 0;
for (cur_seg = 0; cur_seg < i; cur_seg++) {
- struct hugepage_file *hf = &hp[i];
+ struct hugepage_file *hf = &hp[cur_seg];
size_t map_sz = hf->size;
void *map_addr = hf->final_va;
--
2.20.1
next reply other threads:[~2020-01-06 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 20:55 Stephen Hemminger [this message]
2020-01-07 8:43 ` David Marchand
2020-01-07 16:15 ` Burakov, Anatoly
2020-01-22 17:06 ` [dpdk-stable] [PATCH v2] " Stephen Hemminger
2020-02-06 14:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200106205553.3696-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).