From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1DEBA04F8 for ; Tue, 7 Jan 2020 03:31:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B29A81D8ED; Tue, 7 Jan 2020 03:31:40 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E90051D8DC; Tue, 7 Jan 2020 03:31:37 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jan 2020 18:31:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,404,1571727600"; d="scan'208";a="245779197" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by fmsmga004.fm.intel.com with ESMTP; 06 Jan 2020 18:31:35 -0800 Date: Tue, 7 Jan 2020 10:31:38 +0800 From: Tiwei Bie To: Yunjian Wang Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, xudingke@huawei.com, stable@dpdk.org Message-ID: <20200107023138.GA188880@___> References: <1576546577-17048-1-git-send-email-wangyunjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1576546577-17048-1-git-send-email-wangyunjian@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH v2] net/vhost: fix return value of vhost creates not checked X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Dec 17, 2019 at 09:36:17AM +0800, Yunjian Wang wrote: > > - eth_dev_vhost_create(dev, iface_name, queues, dev->device.numa_node, > - flags, disable_flags); > + ret = eth_dev_vhost_create(dev, iface_name, queues, > + dev->device.numa_node, flags, disable_flags); > + if (ret == -1) > + VHOST_LOG(ERR, "Failed to create %s", name); A newline is needed at the end of the error message. Other than that, Reviewed-by: Tiwei Bie