patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Fang TongHao <fangtonghao@sangfor.com.cn>
Cc: thomas@monjalon.net, ferruh.yigit@intel.com,
	arybchenko@solarflare.com, dev@dpdk.org, stable@dpdk.org,
	cunming.liang@intel.com, jia.guo@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory
Date: Fri, 10 Jan 2020 07:32:15 -0800
Message-ID: <20200110073215.09ad9a6f@hermes.lan> (raw)
In-Reply-To: <20200109031425.1338-1-fangtonghao@sangfor.com.cn>

On Thu,  9 Jan 2020 11:14:25 +0800
Fang TongHao <fangtonghao@sangfor.com.cn> wrote:

> Hi all,I am from Sangfor Tech.I found a bug when using DPDK in
> multiprocess scenario.The secondary process enters
> "rte_eth_dev_pci_copy_info" function when initializing.Then it
> sets the value of struct "rte_eth_dev_data.dev_flags" to zero,
> but this struct is shared by primary process and secondary
> process, and the value change is unexpected by primary process.
> This may cause very serious damage.I think
> the secondary process should not enter "rte_eth_dev_pci_copy_info"
> function or changes the value of struct "rte_eth_dev_data.dev_flags"
> in shared memory.
> I fixed this bug by adding an if-statement to forbid the secondary
> process changing the above-mentioned value.
> Thansk, All.
> 
> Signed-off-by: Fang TongHao <fangtonghao@sangfor.com.cn>

Most of the drivers avoid calling rte_eth_dev_pci_copy_info
in the secondary process, which one are you using?

  reply	other threads:[~2020-01-10 15:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  3:14 [dpdk-stable] " Fang TongHao
2020-01-10 15:32 ` Stephen Hemminger [this message]
2020-01-13  3:02   ` [dpdk-stable] [dpdk-dev] " 方统浩50450
  -- strict thread matches above, loose matches on Subject: below --
2020-01-09  2:35 [dpdk-stable] " Fang TongHao
2020-01-15 10:30 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110073215.09ad9a6f@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=arybchenko@solarflare.com \
    --cc=cunming.liang@intel.com \
    --cc=dev@dpdk.org \
    --cc=fangtonghao@sangfor.com.cn \
    --cc=ferruh.yigit@intel.com \
    --cc=jia.guo@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git