* [dpdk-stable] [PATCH 1/2] net/bnxt: do not print error if stats queried before start [not found] <20200122175514.26213-1-stephen@networkplumber.org> @ 2020-01-22 17:55 ` Stephen Hemminger 2020-01-22 17:55 ` [dpdk-stable] [PATCH 2/2] net/bnxt: remove unnecessary memset Stephen Hemminger 1 sibling, 0 replies; 2+ messages in thread From: Stephen Hemminger @ 2020-01-22 17:55 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, ajit.khaparde, stable When using pktgen lots of unnecessary errors are printed because pktgen queries statistics before device is started. Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/net/bnxt/bnxt_stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 20a16a629fb5..65f90e0d8588 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, return rc; memset(bnxt_stats, 0, sizeof(*bnxt_stats)); - if (!(bp->flags & BNXT_FLAG_INIT_DONE)) { - PMD_DRV_LOG(ERR, "Device Initialization not complete!\n"); + if (!(bp->flags & BNXT_FLAG_INIT_DONE)) return -EIO; - } num_q_stats = RTE_MIN(bp->rx_cp_nr_rings, (unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS); -- 2.20.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH 2/2] net/bnxt: remove unnecessary memset [not found] <20200122175514.26213-1-stephen@networkplumber.org> 2020-01-22 17:55 ` [dpdk-stable] [PATCH 1/2] net/bnxt: do not print error if stats queried before start Stephen Hemminger @ 2020-01-22 17:55 ` Stephen Hemminger 1 sibling, 0 replies; 2+ messages in thread From: Stephen Hemminger @ 2020-01-22 17:55 UTC (permalink / raw) To: dev; +Cc: Stephen Hemminger, ajit.khaparde, stable The rte_ethdev layer already zeros statistics before calling the device. Fixes: 57d5e5bc86e4 ("net/bnxt: add statistics") Cc: ajit.khaparde@broadcom.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> --- drivers/net/bnxt/bnxt_stats.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 65f90e0d8588..32f112b5ba35 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -389,7 +389,6 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev, if (rc) return rc; - memset(bnxt_stats, 0, sizeof(*bnxt_stats)); if (!(bp->flags & BNXT_FLAG_INIT_DONE)) return -EIO; -- 2.20.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 17:56 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200122175514.26213-1-stephen@networkplumber.org> 2020-01-22 17:55 ` [dpdk-stable] [PATCH 1/2] net/bnxt: do not print error if stats queried before start Stephen Hemminger 2020-01-22 17:55 ` [dpdk-stable] [PATCH 2/2] net/bnxt: remove unnecessary memset Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).