From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 000FAA04B3 for ; Mon, 3 Feb 2020 04:55:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF6F81BFC1; Mon, 3 Feb 2020 04:55:04 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 643431BFC1; Mon, 3 Feb 2020 04:55:00 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Feb 2020 19:54:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,396,1574150400"; d="scan'208";a="263280379" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 02 Feb 2020 19:54:58 -0800 Date: Mon, 3 Feb 2020 11:54:03 +0800 From: Ye Xiaolong To: "Zhang, Qi Z" Cc: "Cao, Yahui" , "Yang, Qiming" , "Lu, Wenzhuo" , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20200203035403.GK54838@intel.com> References: <20200121134113.27109-1-yahui.cao@intel.com> <20200202082230.GJ54838@intel.com> <039ED4275CED7440929022BC67E7061153E169DE@SHSMSX105.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <039ED4275CED7440929022BC67E7061153E169DE@SHSMSX105.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH] net/ice: fix FDIR gtp_psc without qfi pattern issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Got it, thanks for the info. Thanks, Xiaolong On 02/03, Zhang, Qi Z wrote: >Hi Xiaolong: > Please ignore this one, since it is covered by below patch already > https://patches.dpdk.org/patch/65025/ >Thanks >Qi > >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Sunday, February 2, 2020 4:23 PM >> To: Cao, Yahui >> Cc: Yang, Qiming ; Lu, Wenzhuo >> ; dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z >> >> Subject: Re: [PATCH] net/ice: fix FDIR gtp_psc without qfi pattern issue >> >> On 01/21, Yahui Cao wrote: >> >If only gtpu teid is specified, FDIR will always match the gtpu teid no >> >matter there is gtp extension header appended or not. >> >So forbid pattern in which gtp_psc without qfi value follows gtpu with >> >teid value like: >> >pattern eth / ipv4 / udp / gtpu teid is XXX / gtp_psc / end >> > >> >Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") >> >Cc: stable@dpdk.org >> > >> >Signed-off-by: Yahui Cao >> >--- >> > drivers/net/ice/ice_fdir_filter.c | 12 ++++++++++++ >> >drivers/net/ice/ice_generic_flow.h | 6 ++++++ >> > 2 files changed, 18 insertions(+) >> > >> >diff --git a/drivers/net/ice/ice_fdir_filter.c >> >b/drivers/net/ice/ice_fdir_filter.c >> >index f356581d1..7517299fc 100644 >> >--- a/drivers/net/ice/ice_fdir_filter.c >> >+++ b/drivers/net/ice/ice_fdir_filter.c >> >@@ -1894,6 +1894,18 @@ ice_fdir_parse_pattern(__rte_unused struct >> >ice_adapter *ad, >> > >> > filter->input.gtpu_data.qfi = >> > gtp_psc_spec->qfi; >> >+ } else { >> >+ /* forbid pattern like: >> >+ * "gtpu teid is XXX / gtp_psc / end" >> >+ */ >> >+ if (ice_flow_inset_get_field(input_set, >> >+ ICE_INSET_GTPU_TEID)) { >> >+ rte_flow_error_set(error, EINVAL, >> >+ RTE_FLOW_ERROR_TYPE_ITEM, >> >+ item, >> >+ "Invalid GTP mask"); >> >> Is this a correct message for the error? >> >> Btw, this patch can't be applied cleanly on top of latest dpdk-next-net-intel, >> please help rebase and send a new version. >> >> Thanks, >> Xiaolong >> >> >+ return -rte_errno; >> >+ } >> > } >> > break; >> > default: >> >diff --git a/drivers/net/ice/ice_generic_flow.h >> >b/drivers/net/ice/ice_generic_flow.h >> >index adc30ee2a..8387b5fee 100644 >> >--- a/drivers/net/ice/ice_generic_flow.h >> >+++ b/drivers/net/ice/ice_generic_flow.h >> >@@ -485,4 +485,10 @@ ice_search_pattern_match_item(const struct >> rte_flow_item pattern[], >> > struct ice_pattern_match_item *array, >> > uint32_t array_len, >> > struct rte_flow_error *error); >> >+ >> >+static inline int >> >+ice_flow_inset_get_field(uint64_t input_set, uint64_t field) { >> >+ return (input_set & field) == field; >> >+} >> > #endif >> >-- >> >2.17.1 >> >