Re: [dpdk-stable] [dpdk-dev] [PATCH v4 00/36] update for i40e base code

Re: [dpdk-stable] [dpdk-dev] [PATCH v4 00/36] update for i40e base code

[Kevin Traynor]

On 13/01/2020 05:59, Ye, Xiaolong wrote:
> 
> 
>> -----Original Message-----
>> From: Xing, Beilei
>> Sent: Monday, January 13, 2020 11:26 AM
>> To: Ye, Xiaolong <xiaolong.ye@intel.com>
>> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>
>> Subject: RE: [dpdk-dev] [PATCH v4 00/36] update for i40e base code
>>
>>
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaolong Ye
>>> Sent: Monday, January 13, 2020 10:39 AM
>>> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>
>>> Subject: [dpdk-dev] [PATCH v4 00/36] update for i40e base code
>>>
>>> This series is to support FVL 7.2 release.
>>>
>>> The main changes include:
>>>
>>> * virtchnl updates
>>> * add lldp support
>>> * Flow director updates
>>> * extend PHY access AQ cmd
>>> * add reading LPI counters
>>> * add support for Energy Efficient Ethernet
>>> * A few fixes.
>>>
>>> v4:
>>>
>>> * add a few missed Fixes tags
>>>
>>> V3:
>>>
>>> * add missing SOBs
>>>
>>> V2:
>>>
>>> * strip some unnecessary code
>>> * squash some fixes
>>> * improve commit logs
>>>
>>> Xiaolong Ye (36):
>>>   net/i40e/base: add support for feature flags
>>>   net/i40e/base: increase max VSI count for VFs
>>>   net/i40e/base: change buffer address
>>>   net/i40e/base: decouple cfg_lldp_mib_change from init_dcb
>>>   net/i40e/base: change misleading error message
>>>   net/i40e/base: further implementation of LLDP
>>>   net/i40e/base: add new device ids
>>>   net/i40e/base: add check for MAC type
>>>   net/i40e/base: adding flags for PHY types
>>>   net/i40e/base: improve AQ log granularity
>>>   net/i40e/base: add getter for FW LLDP agent status
>>>   net/i40e/base: add support for Energy Efficient Ethernet
>>>   net/i40e/base: read LPI status from external PHY
>>>   net/i40e/base: change for missing "link modes"
>>>   net/i40e/base: add reading LPI counters
>>>   net/i40e/base: backport style changes from upstream Linux
>>>   net/i40e/base: update status codes
>>>   net/i40e/base: change of the incorrect Tx descriptors number
>>>   net/i40e/base: extend PHY access AQ command
>>>   net/i40e/base: add drop mode parameter to set MAC config
>>>   net/i40e/base: add FWS1B register masks
>>>   net/i40e/base: update FW API version
>>>   net/i40e/base: add persistent lldp support
>>>   net/i40e/base: make i40e_set_mac_type() public
>>>   net/i40e/base: fix retrying logic
>>>   net/i40e/base: mark additional missing bits as reserved
>>>   net/i40e/base: fix wrong 'Advertised FEC modes'
>>>   net/i40e/base: add Flow Director defines
>>>   net/i40e/base: removed unreachable code
>>>   net/i40e/base: set PHY Access flag on X722
>>>   net/i40e/base: implement reading lpi statistics
>>>   net/i40e/base: exposing missing LED functionality
>>>   net/i40e/base: introduce firmware EMP reset register offsets
>>>   net/i40e/base: add CRC stripping capability
>>>   net/i40e/base: enable LED blinking flow
>>>   net/i40e/base: add new link speed constants
>>>
>>>  drivers/net/i40e/base/i40e_adminq.c     | 142 +++---
>>>  drivers/net/i40e/base/i40e_adminq_cmd.h |  95 +++-
>>>  drivers/net/i40e/base/i40e_common.c     | 651 +++++++++++++++++-------
>>>  drivers/net/i40e/base/i40e_dcb.c        |  87 +++-
>>>  drivers/net/i40e/base/i40e_dcb.h        |  20 +-
>>>  drivers/net/i40e/base/i40e_devids.h     |   4 +
>>>  drivers/net/i40e/base/i40e_nvm.c        | 113 +++-
>>>  drivers/net/i40e/base/i40e_prototype.h  |  76 ++-
>>>  drivers/net/i40e/base/i40e_register.h   |  95 ++++
>>>  drivers/net/i40e/base/i40e_type.h       |  39 +-
>>>  drivers/net/i40e/base/virtchnl.h        |  32 +-
>>>  drivers/net/i40e/i40e_ethdev.c          |  12 +-
>>>  drivers/net/i40e/rte_pmd_i40e.c         |   4 +-
>>>  13 files changed, 1047 insertions(+), 323 deletions(-)
>>>
>>> --
>>> 2.17.1
>>
>> Acked-by: Beilei Xing <beilei.xing@intel.com>
> 
> Series applied to dpdk-next-net-intel.
> 
> Thanks,
> Xiaolong
> 

Hi Xiaolong/Beilei/Qi Z,

Some of these patches are tagged to go to 'S'table and are 'F'ixes,
while others are also fixes for older releases but not tagged to go to
stable.

No issue with not backporting patches (in fact i would prefer not if
some doubts), but want to check if the stable tag was missed by accident?

Also, note that Fw listed is v6.01 for 18.11, (v7.00 for 19.11) so
changes would need to be compatible with that.

20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04)
20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0)
20.02 1da546c39 - F net/i40e/base: fix missing link modes (17.08)
20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0)
20.02 50126939c - F net/i40e/base: fix retrying logic (18.02)
20.02 b330a1c5c - F net/i40e/base: fix display of FEC settings (17.08)
20.02 03ef7d47f - F net/i40e/base: add new link speed constants (17.08)

Please confirm on patches above missing stable tag. For time being I
will only consider ones with stable tag.

thanks,
Kevin.

Re: [dpdk-stable] [dpdk-dev] [PATCH v4 00/36] update for i40e base code

[Ye Xiaolong]

Hi, Kevin

On 02/03, Kevin Traynor wrote:
>On 13/01/2020 05:59, Ye, Xiaolong wrote:

[snip]

>>> -----Original Message-----
>Hi Xiaolong/Beilei/Qi Z,
>
>Some of these patches are tagged to go to 'S'table and are 'F'ixes,
>while others are also fixes for older releases but not tagged to go to
>stable.
>
>No issue with not backporting patches (in fact i would prefer not if
>some doubts), but want to check if the stable tag was missed by accident?
>
>Also, note that Fw listed is v6.01 for 18.11, (v7.00 for 19.11) so
>changes would need to be compatible with that.

Yes, some of the stable tags were missed deliberately since the new base code
update is for FW 7.1/7.2, it's not guaranteed to be compatible with old FW.

>
>20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04)
>20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0)
>20.02 1da546c39 - F net/i40e/base: fix missing link modes (17.08)
>20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0)
>20.02 50126939c - F net/i40e/base: fix retrying logic (18.02)
>20.02 b330a1c5c - F net/i40e/base: fix display of FEC settings (17.08)
>20.02 03ef7d47f - F net/i40e/base: add new link speed constants (17.08)
>

I would suggest we only backport below obvious fixes to stable releases.

20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04)
20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0)
20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0)
20.02 50126939c - F net/i40e/base: fix retrying logic (18.02)

Thanks,
Xiaolong

>Please confirm on patches above missing stable tag. For time being I
>will only consider ones with stable tag.
>
>thanks,
>Kevin.
>

Re: [dpdk-stable] [dpdk-dev] [PATCH v4 00/36] update for i40e base code

[Kevin Traynor]

On 04/02/2020 03:23, Ye Xiaolong wrote:
> Hi, Kevin
> 
> On 02/03, Kevin Traynor wrote:
>> On 13/01/2020 05:59, Ye, Xiaolong wrote:
> 
> [snip]
> 
>>>> -----Original Message-----
>> Hi Xiaolong/Beilei/Qi Z,
>>
>> Some of these patches are tagged to go to 'S'table and are 'F'ixes,
>> while others are also fixes for older releases but not tagged to go to
>> stable.
>>
>> No issue with not backporting patches (in fact i would prefer not if
>> some doubts), but want to check if the stable tag was missed by accident?
>>
>> Also, note that Fw listed is v6.01 for 18.11, (v7.00 for 19.11) so
>> changes would need to be compatible with that.
> 
> Yes, some of the stable tags were missed deliberately since the new base code
> update is for FW 7.1/7.2, it's not guaranteed to be compatible with old FW.
> 
>>
>> 20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04)
>> 20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0)
>> 20.02 1da546c39 - F net/i40e/base: fix missing link modes (17.08)
>> 20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0)
>> 20.02 50126939c - F net/i40e/base: fix retrying logic (18.02)
>> 20.02 b330a1c5c - F net/i40e/base: fix display of FEC settings (17.08)
>> 20.02 03ef7d47f - F net/i40e/base: add new link speed constants (17.08)
>>
> 
> I would suggest we only backport below obvious fixes to stable releases.
> 
> 20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04)
> 20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0)
> 20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0)
> 20.02 50126939c - F net/i40e/base: fix retrying logic (18.02)
> 

Thanks for confirming Xialong, I will backport the ones you suggest.

Kevin.

> Thanks,
> Xiaolong
> 
>> Please confirm on patches above missing stable tag. For time being I
>> will only consider ones with stable tag.
>>
>> thanks,
>> Kevin.
>>
>