From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD0D1A051C for ; Tue, 11 Feb 2020 12:22:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88F202B9C; Tue, 11 Feb 2020 12:22:23 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 715FD137D for ; Tue, 11 Feb 2020 12:22:22 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id k11so11830747wrd.9 for ; Tue, 11 Feb 2020 03:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7hxElwqfjEEGseX0BGv0OyNeiZVORCNrlFORq/A78Xs=; b=Yx68WKW2ZGSHakJdjkZv5tWqlMc4+3J1hTYKkwnRGUNIQ5UmMEK4IAM5SK87U0jxH7 hbdURJ07fO9ARKSzvKSGbwspFQI/bqiDtwweVVWhqYbvqxuzImu6TbzebrcsC4qo8fi9 xIWfylxGczqF6vcwScm//t2iTzvL67L/ZvRat/4qfUgo6jwDsPPCBzYi10UnX2fHXuar AL4oYiVzych4rYXz26ChKlNhoaF8OCwXG8WeRrhFvo7a1uqiLeNFkgHfCnUproSLhxNo t68GLsiKfKYJeoeBz38/GHGI7rMfYCIfgDn5c3wQB67xpvosdRIqNeM5qik/rVyz4SG+ Z2+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7hxElwqfjEEGseX0BGv0OyNeiZVORCNrlFORq/A78Xs=; b=fyyRLqGtjYh/S+r4KT5wHtPPlZBb/hwl7/J3mMZ5czoYntHhiy88qjQMrCJkuPHJiY KMuKyrm9OD4Ab98P7P/nm838ccQy8YbrEIIUaYb61KBDjScVDprgvDboL8jUOBsLUnJO ++gFFvPMyy3wuFQsV99Nq8+KprO2mgd8eZzYsg6ulieTeL85CtKHr/hTXM9+JFB9JDwt HFoLa0yiEN3021+ZgWrvzD6lQkpzWNArw1sFmzQpMhEEknYL48YP+DKhJqMkKnk+5WVR 0GX0OC0OmN3sWrD2/QQ4kjTd54psLkvIV16u/K9xb0YAYLejGEKdxtO0w6bphlouWP6n HqRQ== X-Gm-Message-State: APjAAAU/Vs7zgx78wvj5PLNCIA57oefhBZpx12fiM85Mu//LGidVTl75 W5GxvzO7OR6ovVU/G/PC3kY= X-Google-Smtp-Source: APXvYqwkBbSxQh4Hmi0VGXN/bH8HLmEpbuqdo2S43GTgjqimq9WcvMHwv2EMYn6mhTzSAoirQVjzyg== X-Received: by 2002:a5d:4b03:: with SMTP id v3mr8469575wrq.178.1581420142039; Tue, 11 Feb 2020 03:22:22 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id j5sm4910911wrb.33.2020.02.11.03.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:22:21 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: David Marchand , dpdk stable Date: Tue, 11 Feb 2020 11:19:07 +0000 Message-Id: <20200211112216.3929-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal/linux: fix uninitialized data valgrind warning' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From fbb6b70fc5f255c28c18ae1ac7acc5474dfda8d5 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Nov 2019 14:32:32 -0800 Subject: [PATCH] eal/linux: fix uninitialized data valgrind warning [ upstream commit e0ab8020ac2a5b379bb91fbe882ac3b08d333586 ] Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. This is a false positive, because the kernel is not going to care about the unused bits in the union but trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") Signed-off-by: Stephen Hemminger Acked-by: David Marchand --- lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c index 1955324d30..2cd537ba44 100644 --- a/lib/librte_eal/linux/eal/eal_interrupts.c +++ b/lib/librte_eal/linux/eal/eal_interrupts.c @@ -1045,7 +1045,7 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds) static __attribute__((noreturn)) void * eal_intr_thread_main(__rte_unused void *arg) { - struct epoll_event ev; + struct epoll_event ev = { }; /* host thread, never break out */ for (;;) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:38.895759488 +0000 +++ 0001-eal-linux-fix-uninitialized-data-valgrind-warning.patch 2020-02-11 11:17:38.295999402 +0000 @@ -1,15 +1,16 @@ -From e0ab8020ac2a5b379bb91fbe882ac3b08d333586 Mon Sep 17 00:00:00 2001 +From fbb6b70fc5f255c28c18ae1ac7acc5474dfda8d5 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 27 Nov 2019 14:32:32 -0800 Subject: [PATCH] eal/linux: fix uninitialized data valgrind warning +[ upstream commit e0ab8020ac2a5b379bb91fbe882ac3b08d333586 ] + Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. This is a false positive, because the kernel is not going to care about the unused bits in the union but trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: David Marchand