From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4542BA051C
for <public@inbox.dpdk.org>; Tue, 11 Feb 2020 12:39:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 314AB1BFA8;
Tue, 11 Feb 2020 12:39:26 +0100 (CET)
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com
[209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 89FD11BF95
for <stable@dpdk.org>; Tue, 11 Feb 2020 12:39:24 +0100 (CET)
Received: by mail-wm1-f65.google.com with SMTP id s10so3087342wmh.3
for <stable@dpdk.org>; Tue, 11 Feb 2020 03:39:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=Gtw9InY/SREQgj0kK7Gz8xV7u/KDCZ2qyU+zV3rLyLw=;
b=grGeL11MmzMijcGMioIlxHrjBQ0Zpqldae5Vpa8n9KoR1pYYal4BUokMKDQbC0BzEv
+9K6jYDWwZiRQwwTvo4tMsxiXIC+17bdt/rTubh+UYceGAAvagf+mnkhBJPOzEu99ZTi
lTNBNoYWdOI9v44nOxFqXrZlC5wmiRkSvXzHG0t4OSL4Mx5NcNBoJQ23fhyFW5cnoks1
PJrYeUGvrbihfPDnZDpAKLlsFA8f+wKgvEzEFgiovlOlV/i9fY1jSq4MjRRK2+HKMNXL
vIbXHBQ7ERczhJGQCfhyTsZUMSTkvF8jOvliC4wfC4CxaKCQs1sgtmfSa7b+9QtqJ0hM
06oA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=Gtw9InY/SREQgj0kK7Gz8xV7u/KDCZ2qyU+zV3rLyLw=;
b=eL+6W2J1kMaCJrNZ7o8VD+cMa5BZGZrVNLLQKIJ6VQVqzKT7c6srhAqpiZvNb8ukHy
Yq63npSJyIjxOwkYqpZiqX0tYqrWCJOpSJHUrhPd8A0sxnqRIOtOzCvgvbpLnWQiyY1X
rNDc+eQZEd1X7+Uy+i005/VQar1zqM4Rln2Y3DCo80uPNCU2P3kZh1RtllG1PspguABg
6E7lbQIoCV+SUJK9IFNhogUcDydLCQ+bheAV5PGpVBXmEg7EJ657qyNly9j1pENZHC8q
Rdvt5clPIyrLeE+c5B9qd4z5L6JDPxL38vQ1dArxA8T+fBrN5MFz5+FGbjpztP7ZoZxt
/+bw==
X-Gm-Message-State: APjAAAXqn1qG+LDQRcF6+tm5uBNPCc1wNvbVt2W8LNezhhi/VMpt2xll
+KxzAtIOll6XV3KgtxZqYD8=
X-Google-Smtp-Source: APXvYqyrF7DsuXWRGSVYMrG5Bytks9+vPf7+1yhP3khCZMzLonOP0sAODyNR7EgaalbAb6betoEqCw==
X-Received: by 2002:a7b:ce8b:: with SMTP id q11mr5368288wmj.100.1581421164290;
Tue, 11 Feb 2020 03:39:24 -0800 (PST)
Received: from localhost ([88.98.246.218])
by smtp.gmail.com with ESMTPSA id t12sm4960067wrq.97.2020.02.11.03.39.23
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 11 Feb 2020 03:39:23 -0800 (PST)
From: luca.boccassi@gmail.com
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, dpdk stable <stable@dpdk.org>
Date: Tue, 11 Feb 2020 11:21:25 +0000
Message-Id: <20200211112216.3929-139-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com>
References: <20200211112216.3929-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-stable] patch 'net/bnxt: do not log error if stats queried
before start' has been queued to stable release 19.11.1
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
Hi,
FYI, your patch has been queued to stable release 19.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/13/20. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Thanks.
Luca Boccassi
---
>From c4ec740c188c07daa3a50039d3798f9d981fa3b8 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 22 Jan 2020 09:55:13 -0800
Subject: [PATCH] net/bnxt: do not log error if stats queried before start
[ upstream commit d21e0fcc07cdecaaa177f21941bce5be4d333f67 ]
When using pktgen lots of unnecessary errors are printed
because pktgen queries statistics before device is started.
Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_stats.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
index 14d355fd08..20c181dc9b 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
return rc;
memset(bnxt_stats, 0, sizeof(*bnxt_stats));
- if (!(bp->flags & BNXT_FLAG_INIT_DONE)) {
- PMD_DRV_LOG(ERR, "Device Initialization not complete!\n");
+ if (!(bp->flags & BNXT_FLAG_INIT_DONE))
return -EIO;
- }
num_q_stats = RTE_MIN(bp->rx_cp_nr_rings,
(unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS);
--
2.20.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2020-02-11 11:17:43.503023672 +0000
+++ 0139-net-bnxt-do-not-log-error-if-stats-queried-before-st.patch 2020-02-11 11:17:38.652006059 +0000
@@ -1,13 +1,14 @@
-From d21e0fcc07cdecaaa177f21941bce5be4d333f67 Mon Sep 17 00:00:00 2001
+From c4ec740c188c07daa3a50039d3798f9d981fa3b8 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 22 Jan 2020 09:55:13 -0800
Subject: [PATCH] net/bnxt: do not log error if stats queried before start
+[ upstream commit d21e0fcc07cdecaaa177f21941bce5be4d333f67 ]
+
When using pktgen lots of unnecessary errors are printed
because pktgen queries statistics before device is started.
Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
-Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
@@ -16,7 +17,7 @@
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
-index 20a16a629f..65f90e0d85 100644
+index 14d355fd08..20c181dc9b 100644
--- a/drivers/net/bnxt/bnxt_stats.c
+++ b/drivers/net/bnxt/bnxt_stats.c
@@ -390,10 +390,8 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,