From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E64FA051C for ; Tue, 11 Feb 2020 12:27:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54D351BDAE; Tue, 11 Feb 2020 12:27:45 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 243151BDAE for ; Tue, 11 Feb 2020 12:27:44 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id u6so11924885wrt.0 for ; Tue, 11 Feb 2020 03:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f6g+X6Mif3F8VwBfKpELgvtiqgSZ81py6W0xL0tfWX8=; b=uAwCXf5OhNucZX36LL1ThfaxvT6szcK0cKbqCTdCEcX5LL4zT7Mc7RLzNYHJJHzxoK BnXsNM4xh5Z4H4TA31CIsCLO0kaCMpv8sZm9AkABMXmdDGWtRCnYV3rVTCTHvaNruZXr zgE9//Kt1uTj34xiOrrX0doYMHkWi1WE108lTdr/4uSUf4ioiwxJkbXtWUKrkIR3C+7l XxhJ3c7qh3KZ9Adbbj2P138ekpUk15bzoE7hxfbeKVw5CilYvh6hhyUoTTydxSXN+gor dxT8FSprH6tBXhvJZo396Y0a4gknXIMQn0TOI+uOxpsYD2iLibilcrSNEBoRlHSp3HjZ 1HJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f6g+X6Mif3F8VwBfKpELgvtiqgSZ81py6W0xL0tfWX8=; b=s+6e011D8x7Gw2VSmYCmitnzAVvJcU4URctX/kXb6i3G+acc2KVnrTMTbPwvrjbPAS qK9Doxuvx6AQuP5jpQp4hv83ZB7sNNZTEr/mARHlq6sroQqQYQjCjSCfrIAOlCDiDnss iY3geYB06aWpxbi8SGuyNoaxRUAULRL7njV0EnhEIzTqZDj8KJygYwtxEaw9tS1PXo3s EC2HKmh7l0/gCGYmVF4Qlf8OSU2j9fmii8I/ah2m3if4DOJGTM+ikHS18736B3kxMeop 0k2reB/T8qpIP00hPrKp0gqIFrt5IVEgL8h06iDu6VkU62dOUGjCBDc6uCTguk9Nel27 RSjA== X-Gm-Message-State: APjAAAV8+0WylJTllfAFG9vHQbbpn8qEJ8x6ZWnrlkJYd7EFYQcFuR2f rGd+je/SNwIpClONtTGO5eo= X-Google-Smtp-Source: APXvYqwi/TTkstLLitlRRQvyYfL+PqwayUCkb0Fcok/N5hApE8lRUt3Ru6OPtKwu48iAqCb1jVwvhw== X-Received: by 2002:a5d:6703:: with SMTP id o3mr7739521wru.235.1581420463881; Tue, 11 Feb 2020 03:27:43 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s12sm4885175wrw.20.2020.02.11.03.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:27:43 -0800 (PST) From: luca.boccassi@gmail.com To: Santoshkumar Karanappa Rastapur Cc: Somnath Kotur , dpdk stable Date: Tue, 11 Feb 2020 11:20:01 +0000 Message-Id: <20200211112216.3929-55-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix non matching flow hitting filter rule' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 8a0dcafe970bf57a19da6d3aafef313deedfc0b8 Mon Sep 17 00:00:00 2001 From: Santoshkumar Karanappa Rastapur Date: Fri, 20 Dec 2019 18:29:40 -0800 Subject: [PATCH] net/bnxt: fix non matching flow hitting filter rule [ upstream commit 5c63167168138cb5f119372814e62472bbdcd38e ] As part of ntuple filter, we were creating L2 filter with the ntuple redirect queue resulting in any L2 matching flow getting steered to this queue. For ntuple filters, we need to create the L2 filter with default queue. The user specified redirect queue will be set while creating the ntuple filter in hardware. Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") Signed-off-by: Santoshkumar Karanappa Rastapur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index dd40b2d72e..98b1f27bbd 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1126,7 +1126,16 @@ use_vnic: PMD_DRV_LOG(DEBUG, "Setting vnic ff_idx %d\n", vnic->ff_pool_idx); filter->dst_id = vnic->fw_vnic_id; - filter1 = bnxt_get_l2_filter(bp, filter, vnic); + + /* For ntuple filter, create the L2 filter with default VNIC. + * The user specified redirect queue will be set while creating + * the ntuple filter in hardware. + */ + vnic0 = BNXT_GET_DEFAULT_VNIC(bp); + if (use_ntuple) + filter1 = bnxt_get_l2_filter(bp, filter, vnic0); + else + filter1 = bnxt_get_l2_filter(bp, filter, vnic); if (filter1 == NULL) { rte_flow_error_set(error, ENOSPC, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:40.982474881 +0000 +++ 0055-net-bnxt-fix-non-matching-flow-hitting-filter-rule.patch 2020-02-11 11:17:38.428001871 +0000 @@ -1,8 +1,10 @@ -From 5c63167168138cb5f119372814e62472bbdcd38e Mon Sep 17 00:00:00 2001 +From 8a0dcafe970bf57a19da6d3aafef313deedfc0b8 Mon Sep 17 00:00:00 2001 From: Santoshkumar Karanappa Rastapur Date: Fri, 20 Dec 2019 18:29:40 -0800 Subject: [PATCH] net/bnxt: fix non matching flow hitting filter rule +[ upstream commit 5c63167168138cb5f119372814e62472bbdcd38e ] + As part of ntuple filter, we were creating L2 filter with the ntuple redirect queue resulting in any L2 matching flow getting steered to this queue. For ntuple filters, we need to create the L2 filter with @@ -10,7 +12,6 @@ creating the ntuple filter in hardware. Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") -Cc: stable@dpdk.org Signed-off-by: Santoshkumar Karanappa Rastapur Signed-off-by: Somnath Kotur @@ -19,7 +20,7 @@ 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c -index 7343b7e7b4..855994a6b0 100644 +index dd40b2d72e..98b1f27bbd 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1126,7 +1126,16 @@ use_vnic: