From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F0FA051C for ; Tue, 11 Feb 2020 12:28:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3986D1BF95; Tue, 11 Feb 2020 12:28:08 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 2C98E1BF95 for ; Tue, 11 Feb 2020 12:28:07 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id k11so11856353wrd.9 for ; Tue, 11 Feb 2020 03:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+B+Ok0c+/miR4+YXlV8WAMvttDdt/GnprjAXkOTy5jE=; b=mgi6ZU20+WbdwfBesomFvsOp5LUti6LneSngPWkeQpC2us/utxryRl+qvZWC5Pj/UR hG2xYOfiZQbKbYsLoI6aSt2zSTI7Pl+F11Sop8QV81MvLxTSmVq+HCJLSDDWFj7mfoOE +IJ/vJ8tbsH7rXFaQrKaGzLxUeBRiois2ZQKmadLSO4TnszsKKOb7jNgNXzCkX2o7PyN jtjrX5YfamtaXQ05gfGcA036lAnbnC3+JOLgZKheVEb6ovIWtBQGzNKtHTAnn5sCfbeI 3pJYI4IZnTXc9p/C7/ZglOfOoUJ5T5fzOMg0eg/Syyv+978LsHWwESnTBfeharVhhO3e jFww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+B+Ok0c+/miR4+YXlV8WAMvttDdt/GnprjAXkOTy5jE=; b=qcI5DqgLm3klJwyu2l6oVOhbV9ovBiVvL5muPjAOCxyVBmC0VEC43VpF/1bxuSXXbs r1PTIROaQn7jBEYY9ggEzymXrn7Hoz1nt77cB6ArFDEZWvdcHSL81rABk3hSAI4iOTgq jiROLSfC4BnHN7rkK8VN8xmpiHIDKCJSHBo6AjYJjsKzUOOQ7rwv4MaryBcrVRSW6FUD IQ7DN0wpjq5b9iOG49+oNQIMquXU6cR6xHFL97UfV+UnPdGajmy71HGbUu3zyfuP4HRR K3Vd1V4Ujk+FB2v7nd0edbneIxxZ/HnFHYYfkK5wMZ+uE9XAmSViQi4AH1XhS4FfgL5h +P0Q== X-Gm-Message-State: APjAAAUsP/UOii1Boxo16RMzygvo4bqX8tPCTkiOhBVENLEJ++yIzJKN OwQuPcoHiLYQo8YIomcxK/0A7Y47LAw= X-Google-Smtp-Source: APXvYqxiEPNkOaxX8InF3QnC/Tvzv9JRHyFWbIHhNqvs4qJlHGkbQQbRfTqlxWSOY0nbWLcw3FHWTA== X-Received: by 2002:adf:e88f:: with SMTP id d15mr7790493wrm.186.1581420486873; Tue, 11 Feb 2020 03:28:06 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id g2sm4777141wrw.76.2020.02.11.03.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:28:06 -0800 (PST) From: luca.boccassi@gmail.com To: Harman Kalra Cc: Jerin Jacob , dpdk stable Date: Tue, 11 Feb 2020 11:20:13 +0000 Message-Id: <20200211112216.3929-67-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/octeontx2: fix getting supported packet types' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a691fd0281c5683c39b19df1bc9a9d6df0ac6aaf Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Thu, 12 Dec 2019 17:58:56 +0000 Subject: [PATCH] net/octeontx2: fix getting supported packet types [ upstream commit 348123a3df8c679b2fcf56ec767c2bc319ec8bf9 ] Setting up supported ptypes using testpmd command is failing because supported_ptypes_get callback will never return ptypes supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags is zero by default in testpmd. Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") Signed-off-by: Harman Kalra Acked-by: Jerin Jacob --- drivers/net/octeontx2/otx2_lookup.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c index bcf2ff4e8f..5685571166 100644 --- a/drivers/net/octeontx2/otx2_lookup.c +++ b/drivers/net/octeontx2/otx2_lookup.c @@ -17,7 +17,7 @@ const uint32_t * otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) { - struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); + RTE_SET_USED(eth_dev); static const uint32_t ptypes[] = { RTE_PTYPE_L2_ETHER_QINQ, /* LB */ @@ -56,10 +56,7 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) RTE_PTYPE_UNKNOWN, }; - if (dev->rx_offload_flags & NIX_RX_OFFLOAD_PTYPE_F) - return ptypes; - else - return NULL; + return ptypes; } int -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:41.340359542 +0000 +++ 0067-net-octeontx2-fix-getting-supported-packet-types.patch 2020-02-11 11:17:38.460002469 +0000 @@ -1,15 +1,16 @@ -From 348123a3df8c679b2fcf56ec767c2bc319ec8bf9 Mon Sep 17 00:00:00 2001 +From a691fd0281c5683c39b19df1bc9a9d6df0ac6aaf Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Thu, 12 Dec 2019 17:58:56 +0000 Subject: [PATCH] net/octeontx2: fix getting supported packet types +[ upstream commit 348123a3df8c679b2fcf56ec767c2bc319ec8bf9 ] + Setting up supported ptypes using testpmd command is failing because supported_ptypes_get callback will never return ptypes supported, as NIX_RX_OFFLOAD_PTYPE_F bit in rx_offload_flags is zero by default in testpmd. Fixes: d2706e15e6fb ("net/octeontx2: support reduced set of packet types") -Cc: stable@dpdk.org Signed-off-by: Harman Kalra Acked-by: Jerin Jacob