From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42FC2A051C for ; Tue, 11 Feb 2020 12:22:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39E142BF4; Tue, 11 Feb 2020 12:22:37 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by dpdk.org (Postfix) with ESMTP id 7E3D71BE90 for ; Tue, 11 Feb 2020 12:22:36 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id w12so11884443wrt.2 for ; Tue, 11 Feb 2020 03:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D6bZ2QhN7IPEzXhGbmTDccVQa0Pr/Xm18aUemPfn9l0=; b=jv1XdiXZZEbmtSHUNcj+tLXJB2tlT16/GJsRfiSIprYjESRS7zed52OMC2iGS6eKbb 2vMEdNUCKVCA7fP7Da80vbT2nuOk6izaqQjuiUJ62Fx2TRPbLf4QCPqtXrmyjlnE959I CX+uaoXapRf8CQDQicNh5LGbpDjIHOJwTaAyY3rNXhkxR12neRrEnUE0xniJOJzNuAbl SVI3113HTQPEtIPa8F2j3TSlBiyneZD5Ca8POnGMzuZMXn+N9aU2NYRDqOpEY+4LXnAX UpPNurI+tFJuUi+Sy6bnrGF3GAuMIYNer4bdJvJa1P7Cw5SsHaFL84OvJdHL2ohpA/ar xY8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D6bZ2QhN7IPEzXhGbmTDccVQa0Pr/Xm18aUemPfn9l0=; b=iZ+L4PUI4/capi5RH3Nt+ENo5PECcJ0nlBXPvzVwYJ6ERBONZ5+qo8Af9LaBLhVARl G0hzNT+Nq6WlvBPyeUaCserNPhBqY7W9/ZZXvqlV3hgddKfZ40dw1vfGWrTNkCK/g9b3 yULfUSA5C+IiH/2ryx2kp6cqUS5//OnKouZpvyi+fZa0Pcwp1eHne1niz6ONPdXWKb8v KSB3NJi2utGNSI7kLKMRnT46M/ZiHuTxbz7BKH+fNDt5BROVto5U3z0oc3o9237A9G/s gW3l0gIgP2B7OZKOgoBqMavk+pcvrASySCqDbCXprPPjlcCjoofBRtGe43/g9iCYVAwK xIIA== X-Gm-Message-State: APjAAAV8IHUXc6OmEvnSVRoP6YJWXAbOBTAudgjRW52jS5nbwsxZ+Rst VTcDAtCyvkvsYt+m3PIBaTA= X-Google-Smtp-Source: APXvYqxRwQHRujyYgA4bBvcR5d/ICjxxooLTQLscW2P7ucwIMaRVvXQNDuOedvGurtuxG6ipr9fpiA== X-Received: by 2002:a5d:538e:: with SMTP id d14mr8434249wrv.358.1581420156268; Tue, 11 Feb 2020 03:22:36 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b21sm3468324wmd.37.2020.02.11.03.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 03:22:35 -0800 (PST) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: David Marchand , dpdk stable Date: Tue, 11 Feb 2020 11:19:14 +0000 Message-Id: <20200211112216.3929-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200211112216.3929-1-luca.boccassi@gmail.com> References: <20200211112216.3929-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'build: explicitly enable sse4 for meson' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/13/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 6bcb93c8232d3ddc2547018acd18e94e93acb85c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 23 Dec 2019 10:38:40 +0000 Subject: [PATCH] build: explicitly enable sse4 for meson [ upstream commit 10060dba6455461088d24e03d3cfeba639d53022 ] If the compiler does not recognise the specific CPU when building with the default "native" machine type, sse4.2 instructions can be missing, causing a build error. Rather than advising the user to change the machine type, we can just turn on SSE4.2 directly. This can prevent issues with running automated tests with older compilers/distros on newer hardware. Signed-off-by: Bruce Richardson Acked-by: David Marchand --- config/x86/meson.build | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 8b0fa3e6f1..adc857ba28 100644 --- a/config/x86/meson.build +++ b/config/x86/meson.build @@ -15,11 +15,9 @@ if not is_windows endif # we require SSE4.2 for DPDK -sse_errormsg = '''SSE4.2 instruction set is required for DPDK. -Please set the machine type to "nehalem" or "corei7" or higher value''' - if cc.get_define('__SSE4_2__', args: machine_args) == '' - error(sse_errormsg) + message('SSE 4.2 not enabled by default, explicitly enabling') + machine_args += '-msse4' endif base_flags = ['SSE', 'SSE2', 'SSE3','SSSE3', 'SSE4_1', 'SSE4_2'] -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-11 11:17:39.246524312 +0000 +++ 0008-build-explicitly-enable-sse4-for-meson.patch 2020-02-11 11:17:38.307999627 +0000 @@ -1,16 +1,16 @@ -From 10060dba6455461088d24e03d3cfeba639d53022 Mon Sep 17 00:00:00 2001 +From 6bcb93c8232d3ddc2547018acd18e94e93acb85c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Mon, 23 Dec 2019 10:38:40 +0000 Subject: [PATCH] build: explicitly enable sse4 for meson +[ upstream commit 10060dba6455461088d24e03d3cfeba639d53022 ] + If the compiler does not recognise the specific CPU when building with the default "native" machine type, sse4.2 instructions can be missing, causing a build error. Rather than advising the user to change the machine type, we can just turn on SSE4.2 directly. This can prevent issues with running automated tests with older compilers/distros on newer hardware. -Cc: stable@dpdk.org - Signed-off-by: Bruce Richardson Acked-by: David Marchand ---