From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01E5FA054C for ; Fri, 14 Feb 2020 18:05:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED67DF72; Fri, 14 Feb 2020 18:05:44 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 2695BF72 for ; Fri, 14 Feb 2020 18:05:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581699943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yu+9tKtHQ1xia/Toa0tpaqLSCzSennredeHtDzKhAMQ=; b=hjHuC7Tm2jlydbhGHLsgDLBMxhouDLGeL8vANStkTWm/SI+1KqsYRlQwA/KUHuGcBkBvsb dL3L2B8qiFXLKm1uQhqjs9ioT6cKdTYOZPNOoinFp29yDliQKdU/HUpj/4u4lMFc1rVEZc aBmoDH9jkks7twzAGfcSMAfIiu58gyc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-aU5ipFWeMnegL9_MD0KSEQ-1; Fri, 14 Feb 2020 12:05:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C235718C35A9; Fri, 14 Feb 2020 17:05:37 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id D446984BCD; Fri, 14 Feb 2020 17:05:32 +0000 (UTC) From: Kevin Traynor To: "Wei Hu (Xavier)" Cc: Huisong Li , Xuan Li , Ferruh Yigit , dpdk stable Date: Fri, 14 Feb 2020 17:03:23 +0000 Message-Id: <20200214170337.25093-29-ktraynor@redhat.com> In-Reply-To: <20200214170337.25093-1-ktraynor@redhat.com> References: <20200214170337.25093-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: aU5ipFWeMnegL9_MD0KSEQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'app/testpmd: fix uninitialized members when setting PFC' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/20/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/cd25180193ae4d4162= 025b0be5ecfb93b3b93562 Thanks. Kevin. --- >From cd25180193ae4d4162025b0be5ecfb93b3b93562 Mon Sep 17 00:00:00 2001 From: "Wei Hu (Xavier)" Date: Tue, 21 Jan 2020 19:44:33 +0800 Subject: [PATCH] app/testpmd: fix uninitialized members when setting PFC [ upstream commit 8a433297282662460a951882c80b5b0d5a8d88cf ] Only a part of members in the local structure variable named pfc_conf are initialized in the function named cmd_priority_flow_ctrl_set_parsed when typing "set pfc_ctrl..." command, and others are random values. However, those uninitialized members may cause failure. This patch adds clearing zero operation before calling the API named rte_eth_dev_priority_flow_ctrl_set API with pfc_conf as the input parameter. Fixes: 9b53e542e9e1 ("app/testpmd: add priority flow control") Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) Signed-off-by: Xuan Li Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a8b53b89cf..27ce5d1880 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -6903,4 +6903,5 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_result= , =09}; =20 +=09memset(&pfc_conf, 0, sizeof(struct rte_eth_pfc_conf)); =09rx_fc_enable =3D (!strncmp(res->rx_pfc_mode, "on",2)) ? 1 : 0; =09tx_fc_enable =3D (!strncmp(res->tx_pfc_mode, "on",2)) ? 1 : 0; --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-14 17:02:38.668524239 +0000 +++ 0029-app-testpmd-fix-uninitialized-members-when-setting-P.patch=092020-= 02-14 17:02:37.037406144 +0000 @@ -1 +1 @@ -From 8a433297282662460a951882c80b5b0d5a8d88cf Mon Sep 17 00:00:00 2001 +From cd25180193ae4d4162025b0be5ecfb93b3b93562 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a433297282662460a951882c80b5b0d5a8d88cf ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 06672fd04e..de7a695d74 100644 +index a8b53b89cf..27ce5d1880 100644 @@ -30 +31 @@ -@@ -7090,4 +7090,5 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_resul= t, +@@ -6903,4 +6903,5 @@ cmd_priority_flow_ctrl_set_parsed(void *parsed_resul= t,