From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4247A0555 for ; Wed, 19 Feb 2020 16:57:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBD9F1BF84; Wed, 19 Feb 2020 16:57:19 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id F36991BF7C for ; Wed, 19 Feb 2020 16:57:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582127837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E7FTIE40Y/12VX6iD9tGiEMvTQfXUXBtPshFUtQafL4=; b=RqajHU4r4KBKnvaigKP15C6Ag2SAiD3nTZFev3eIEry8xcUFKns0EeDkcj9gZKHf1AGJsN e7fXvQsv45AqJwhadsPN+z8Xs2AvyPnYelxazhaUqtyd7B4U+iaxekw9jPE6SNM6QXmOvv vGrpKBxebGFQAbpc97O5nAlKtvgl5tA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-Luaizq9oMVq89BNgS_RGvg-1; Wed, 19 Feb 2020 10:57:13 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64FA3107ACC5; Wed, 19 Feb 2020 15:57:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8EAF811F8; Wed, 19 Feb 2020 15:57:10 +0000 (UTC) From: Kevin Traynor To: Junxiao Shi Cc: dpdk stable Date: Wed, 19 Feb 2020 15:55:56 +0000 Message-Id: <20200219155607.20495-11-ktraynor@redhat.com> In-Reply-To: <20200219155607.20495-1-ktraynor@redhat.com> References: <20200219155607.20495-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: Luaizq9oMVq89BNgS_RGvg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'drivers/crypto: fix session-less mode' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fc86473e334566d706= 198a26022ff8c617e3e806 Thanks. Kevin. --- >From fc86473e334566d706198a26022ff8c617e3e806 Mon Sep 17 00:00:00 2001 From: Junxiao Shi Date: Mon, 27 Jan 2020 11:32:11 -0700 Subject: [PATCH] drivers/crypto: fix session-less mode [ upstream commit a0c2b3d8ee501b90eb11c2a82da0aaca19362bd3 ] When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode for symmetric crypto operation (e.g. SHA256 hash), the driver prints error message: CRYPTODEV: set_sym_session_private_data() line 489: Set private data for driver 0 not allowed Then, AESNI-MB driver segfaults in post_process_mb_job(). Bugzilla ID: 377 Fixes: b3bbd9e5f2 ("cryptodev: support device independent sessions") Fixes: c68d7aa354 ("crypto/aesni_mb: use architecture independent macros") Signed-off-by: Junxiao Shi --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/ae= sni_mb/rte_aesni_mb_pmd.c index 83250e32cc..45dd86a756 100644 --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c @@ -663,8 +663,8 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_o= p *op) =09=09=09=09=09cryptodev_driver_id); =09} else { -=09=09void *_sess =3D NULL; +=09=09void *_sess =3D rte_cryptodev_sym_session_create(qp->sess_mp); =09=09void *_sess_private_data =3D NULL; =20 -=09=09if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) +=09=09if (_sess =3D=3D NULL) =09=09=09return NULL; =20 diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/open= ssl/rte_openssl_pmd.c index 90a91bd831..36122a43ce 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -763,8 +763,8 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op= *op) =20 =09=09/* provide internal session */ -=09=09void *_sess =3D NULL; +=09=09void *_sess =3D rte_cryptodev_sym_session_create(qp->sess_mp); =09=09void *_sess_private_data =3D NULL; =20 -=09=09if (rte_mempool_get(qp->sess_mp, (void **)&_sess)) +=09=09if (_sess =3D=3D NULL) =09=09=09return NULL; =20 --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-19 15:43:50.295775677 +0000 +++ 0011-drivers-crypto-fix-session-less-mode.patch=092020-02-19 15:43:49.7= 33141952 +0000 @@ -1 +1 @@ -From a0c2b3d8ee501b90eb11c2a82da0aaca19362bd3 Mon Sep 17 00:00:00 2001 +From fc86473e334566d706198a26022ff8c617e3e806 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a0c2b3d8ee501b90eb11c2a82da0aaca19362bd3 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 97d9f81766..33f4167452 100644 +index 83250e32cc..45dd86a756 100644 @@ -30 +31 @@ -@@ -730,8 +730,8 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_= op *op) +@@ -663,8 +663,8 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_= op *op) @@ -42 +43 @@ -index 91f028308c..199097bf8c 100644 +index 90a91bd831..36122a43ce 100644