From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 806DAA0555 for ; Wed, 19 Feb 2020 16:57:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78C95B62; Wed, 19 Feb 2020 16:57:57 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id C894C1BF8E for ; Wed, 19 Feb 2020 16:57:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582127875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7rTVq203JSgewdg8gTvQyWymdCMpnTgezppifMo1pQ=; b=OdKNE3z+Wn56l019YggDRbhq+9U4bdaxtRxkPZsP/6dah1dZ0IfBUUnkOk78zFoyUiS6Bw aBYvNWcq6t9FE+1xSP9HB9qMpf2w1n5cXVze2ox+QMGcfR9Hw7zag7TA5iRWtwaXrzU0AV 8wVnC54/pVrxIBlI3fvqbd/s0J3nCss= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-384-OQI_ROpWPoq9n2A_C2929A-1; Wed, 19 Feb 2020 10:57:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16979100DFC5; Wed, 19 Feb 2020 15:57:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FEF488859; Wed, 19 Feb 2020 15:57:47 +0000 (UTC) From: Kevin Traynor To: Beilei Xing Cc: Xiaolong Ye , dpdk stable Date: Wed, 19 Feb 2020 15:56:04 +0000 Message-Id: <20200219155607.20495-19-ktraynor@redhat.com> In-Reply-To: <20200219155607.20495-1-ktraynor@redhat.com> References: <20200219155607.20495-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: OQI_ROpWPoq9n2A_C2929A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/i40e: fix unchecked Tx cleanup error' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/ef6860fb6586ab2f12= c0ac120df0afa953b3883a Thanks. Kevin. --- >From ef6860fb6586ab2f12c0ac120df0afa953b3883a Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Wed, 12 Feb 2020 20:36:01 +0800 Subject: [PATCH] net/i40e: fix unchecked Tx cleanup error [ upstream commit ba950e62762bd0198e53666ecc2a791767adc137 ] Coverity complains of unchecked return value warning of i40e_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of i40e_xmit_cleanup and return in case of cleanup failure, we directly cast it to void function to make the Coverity happy. Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing Acked-by: Xiaolong Ye --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index 1642cf4948..e4a314f4ab 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1053,5 +1053,5 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_p= kts, uint16_t nb_pkts) =09/* Check if the descriptor ring needs to be cleaned. */ =09if (txq->nb_tx_free < txq->tx_free_thresh) -=09=09i40e_xmit_cleanup(txq); +=09=09(void)i40e_xmit_cleanup(txq); =20 =09for (nb_tx =3D 0; nb_tx < nb_pkts; nb_tx++) { --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-19 15:43:50.716654569 +0000 +++ 0019-net-i40e-fix-unchecked-Tx-cleanup-error.patch=092020-02-19 15:43:4= 9.765141303 +0000 @@ -1 +1 @@ -From ba950e62762bd0198e53666ecc2a791767adc137 Mon Sep 17 00:00:00 2001 +From ef6860fb6586ab2f12c0ac120df0afa953b3883a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba950e62762bd0198e53666ecc2a791767adc137 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index fd1ae80da8..f6d23c9fb6 100644 +index 1642cf4948..e4a314f4ab 100644 @@ -26 +27 @@ -@@ -1040,5 +1040,5 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_= pkts, uint16_t nb_pkts) +@@ -1053,5 +1053,5 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_= pkts, uint16_t nb_pkts)