From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E43CA0555 for ; Wed, 19 Feb 2020 16:56:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D1B21B951; Wed, 19 Feb 2020 16:56:42 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id A902A1BF84 for ; Wed, 19 Feb 2020 16:56:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582127800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23ZaNS2PXLeCCpLgoTd3rqwU/OG7O5Rw1OmJCJB6XYc=; b=NRLtRSUyC1lwBqe3aCv7CaMQEKJ/zCsT3tDyuqGsSS7RSq6RM4GFMRBtnf5ofwqKP2dj4B dPrKorzIAcKEW0mqzcBLNwYCl8mvCXzF1RMaFVfSkddviT12qXCaHKxw8iTdz3hTISLnTk zjvmPsn2SdkpmZqGLlFl86M6k4Bis6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-4UFvP-4zM1-VQccdv8T6gg-1; Wed, 19 Feb 2020 10:56:33 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D6176477; Wed, 19 Feb 2020 15:56:31 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A16A8B757; Wed, 19 Feb 2020 15:56:28 +0000 (UTC) From: Kevin Traynor To: Gargi Sau Cc: Bruce Richardson , dpdk stable Date: Wed, 19 Feb 2020 15:55:47 +0000 Message-Id: <20200219155607.20495-2-ktraynor@redhat.com> In-Reply-To: <20200219155607.20495-1-ktraynor@redhat.com> References: <20200219155607.20495-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 4UFvP-4zM1-VQccdv8T6gg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'examples/ethtool: fix unchecked return value' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/2042297f9d2e9c1b89= 167fea325ddaa5f7fccac2 Thanks. Kevin. --- >From 2042297f9d2e9c1b89167fea325ddaa5f7fccac2 Mon Sep 17 00:00:00 2001 From: Gargi Sau Date: Mon, 9 Dec 2019 06:37:56 +0000 Subject: [PATCH] examples/ethtool: fix unchecked return value [ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ] This checks the return value from the function rte_eth_dev_set_vlan_offload. Coverity issue: 350358 Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample appli= cation") Signed-off-by: Gargi Sau Acked-by: Bruce Richardson --- examples/ethtool/lib/rte_ethtool.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_= ethtool.c index 63344376c8..eba7dd9ac8 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -371,4 +371,5 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) =09struct rte_eth_dev_info dev_info; =09uint16_t vf; +=09int ret; =20 =09rte_eth_dev_info_get(port_id, &dev_info); @@ -384,5 +385,7 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) =20 =09/* Enable Rx vlan filter, VF unspport status is discard */ -=09rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK); +=09ret =3D rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK); +=09if (ret !=3D 0) +=09=09return ret; =20 =09return 0; --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-19 15:43:49.857832385 +0000 +++ 0002-examples-ethtool-fix-unchecked-return-value.patch=092020-02-19 15:= 43:49.713142357 +0000 @@ -1 +1 @@ -From 899f6de24bb6504d56369aef5f55bb370d58784d Mon Sep 17 00:00:00 2001 +From 2042297f9d2e9c1b89167fea325ddaa5f7fccac2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -16,2 +17,2 @@ - examples/ethtool/lib/rte_ethtool.c | 4 +++- - 1 file changed, 3 insertions(+), 1 deletion(-) + examples/ethtool/lib/rte_ethtool.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) @@ -20 +21 @@ -index 667d7eaf27..db8150efd5 100644 +index 63344376c8..eba7dd9ac8 100644 @@ -23 +24,7 @@ -@@ -403,5 +403,7 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) +@@ -371,4 +371,5 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) + =09struct rte_eth_dev_info dev_info; + =09uint16_t vf; ++=09int ret; +=20 + =09rte_eth_dev_info_get(port_id, &dev_info); +@@ -384,5 +385,7 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)