From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB992A0555 for ; Wed, 19 Feb 2020 16:57:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A3F38B62; Wed, 19 Feb 2020 16:57:08 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 6661AB62 for ; Wed, 19 Feb 2020 16:57:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582127826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RV+Rr1qf2QkhpAE19ahSCaHX04PTBjy/4LNHz2cx3fE=; b=ftRsK6cDDKmKIoBjGklXW6qy8MMg/EV78HvFk8jmXdINF/1+81cGynJkgKE17/UxFcxGQ/ Kk8cl55ncPFn8gEmty/UWTmnU13VY6t8cxeal40LDAN6JFSwOvkIpzEMAT15RlKCxpeofb evvkeoOj02tyWVkyqleLdBM0GL2VSpY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-2G_tXxFuPR-tng4BX4zhdw-1; Wed, 19 Feb 2020 10:57:03 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8DA3C1005512; Wed, 19 Feb 2020 15:57:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.109]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38AB9811F8; Wed, 19 Feb 2020 15:56:57 +0000 (UTC) From: Kevin Traynor To: Ciara Power Cc: Ferruh Yigit , Olivier Matz , dpdk stable Date: Wed, 19 Feb 2020 15:55:53 +0000 Message-Id: <20200219155607.20495-8-ktraynor@redhat.com> In-Reply-To: <20200219155607.20495-1-ktraynor@redhat.com> References: <20200219155607.20495-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 2G_tXxFuPR-tng4BX4zhdw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'lib: fix unnecessary double negation' has been queued to LTS release 18.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/25/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/368b63ca65b313dde4= e85d85ea5a926914c4b207 Thanks. Kevin. --- >From 368b63ca65b313dde4e85d85ea5a926914c4b207 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 14 Feb 2020 16:17:25 +0000 Subject: [PATCH] lib: fix unnecessary double negation [ upstream commit f42c9ac5b6b5fabd3c6bb124914af6704445e853 ] An equality expression already returns either 0 or 1. There is no need to use double negation for these cases. Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") Signed-off-by: Ciara Power Reviewed-by: Ferruh Yigit Acked-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf.h | 2 +- lib/librte_mempool/rte_mempool.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 8eab5a836b..56406f15c9 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -2093,5 +2093,5 @@ static inline int rte_pktmbuf_is_contiguous(const str= uct rte_mbuf *m) { =09__rte_mbuf_sanity_check(m, 1); -=09return !!(m->nb_segs =3D=3D 1); +=09return m->nb_segs =3D=3D 1; } =20 diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_memp= ool.h index a22cef49e0..217fd34b57 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/lib/librte_mempool/rte_mempool.h @@ -1574,5 +1574,5 @@ static inline int rte_mempool_full(const struct rte_mempool *mp) { -=09return !!(rte_mempool_avail_count(mp) =3D=3D mp->size); +=09return rte_mempool_avail_count(mp) =3D=3D mp->size; } =20 @@ -1593,5 +1593,5 @@ static inline int rte_mempool_empty(const struct rte_mempool *mp) { -=09return !!(rte_mempool_avail_count(mp) =3D=3D 0); +=09return rte_mempool_avail_count(mp) =3D=3D 0; } =20 --=20 2.21.1 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092020-02-19 15:43:50.145205864 +0000 +++ 0008-lib-fix-unnecessary-double-negation.patch=092020-02-19 15:43:49.72= 8142053 +0000 @@ -1 +1 @@ -From f42c9ac5b6b5fabd3c6bb124914af6704445e853 Mon Sep 17 00:00:00 2001 +From 368b63ca65b313dde4e85d85ea5a926914c4b207 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f42c9ac5b6b5fabd3c6bb124914af6704445e853 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 59023893a5..34679e0920 100644 +index 8eab5a836b..56406f15c9 100644 @@ -25 +26 @@ -@@ -1700,5 +1700,5 @@ static inline int rte_pktmbuf_is_contiguous(const st= ruct rte_mbuf *m) +@@ -2093,5 +2093,5 @@ static inline int rte_pktmbuf_is_contiguous(const st= ruct rte_mbuf *m) @@ -33 +34 @@ -index a2c92727a6..c90cf31467 100644 +index a22cef49e0..217fd34b57 100644 @@ -36 +37 @@ -@@ -1655,5 +1655,5 @@ static inline int +@@ -1574,5 +1574,5 @@ static inline int @@ -43 +44 @@ -@@ -1674,5 +1674,5 @@ static inline int +@@ -1593,5 +1593,5 @@ static inline int